patch-remove-perlexperimental #78

marko · 2025-10-14T05:20:52Z

marko commented

2025-10-14 05:20:52 +00:00

No description provided.

marko added 5 commits 2025-10-14 05:20:52 +00:00

Merge pull request 'dev' (#75 ) from dev into main 2db8db3b89

Reviewed-on: #75

Refactor language initialization and attribute handling 2e3210c438

Improved the language initialization logic by replacing
the experimental `given/when` construct with a more
standard `if/elsif` structure. This change enhances code
readability and maintainability, making it easier to follow
the flow of language assignments.

Additionally, refactored attribute handling in the `Attr`
subroutine by streamlining the conditions, removing
unnecessary `given/when` usage, and maintaining clarity
in the logic for setting and deleting forecasts and alerts.
These changes help reduce complexity and improve
consistency throughout the codebase.

Refactor language handling to improve readability d313cb8d4a

Improved the language initialization logic by replacing the
experimental `given/when` construct with a more standard
`if/elsif` structure, enhancing code readability and
maintainability. Additionally, the attribute handling in the
`Attr` subroutine was refactored for clarity, removing
unnecessary usage of `given/when`, which helps reduce
complexity across the codebase.

Furthermore, in the OpenWeatherMapAPI module, logic for
handling weather response data was streamlined by removing
the `given/when` statements in favor of `if` conditions.
This change eliminates potential confusion and enhances
the clarity of the code logic. No breaking changes were
introduced; the overall functionality remains intact.

Refactor language handling in Weather API f37a24673c

Improved the language initialization logic by replacing the
experimental `given/when` construct with a more standard
`if/elsif` structure, enhancing code readability and
maintainability. The attribute handling in the `Attr` subroutine
was also refactored for clarity, removing unnecessary usage
of `given/when`, which helps reduce complexity throughout
the codebase.

In the OpenWeatherMapAPI module, the logic for handling
weather response data was streamlined by removing `given/when`
statements in favor of `if` conditions. This change avoids
potential confusion and enhances the clarity of the code logic.
No breaking changes were introduced; the overall functionality
remains intact.

Refactor language handling in Weather API 14644b8575

Improved the language initialization logic by replacing the
experimental `given/when` construct with a more standard
`if/elsif` structure to enhance code readability and
maintainability. The attribute handling in the `Attr` subroutine
was simplified for clarity, removing unnecessary usage
of `given/when`, which helps reduce complexity throughout
the codebase.

Additionally, in the OpenWeatherMapAPI module, the logic for
handling weather response data was streamlined by removing
`given/when` statements in favor of `if` conditions. This change
avoids potential confusion and enhances the clarity of the
code logic. No breaking changes were introduced; the overall
functionality remains intact.

marko merged commit 14644b8575 into dev

2025-10-14 05:20:57 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FHEM/mod-Weather#78