Commit Graph

258 Commits

Author SHA1 Message Date
14644b8575 Refactor language handling in Weather API
Improved the language initialization logic by replacing the
experimental `given/when` construct with a more standard
`if/elsif` structure to enhance code readability and
maintainability. The attribute handling in the `Attr` subroutine
was simplified for clarity, removing unnecessary usage
of `given/when`, which helps reduce complexity throughout
the codebase.

Additionally, in the OpenWeatherMapAPI module, the logic for
handling weather response data was streamlined by removing
`given/when` statements in favor of `if` conditions. This change
avoids potential confusion and enhances the clarity of the
code logic. No breaking changes were introduced; the overall
functionality remains intact.
2025-10-14 07:04:00 +02:00
f37a24673c Refactor language handling in Weather API
Improved the language initialization logic by replacing the
experimental `given/when` construct with a more standard
`if/elsif` structure, enhancing code readability and
maintainability. The attribute handling in the `Attr` subroutine
was also refactored for clarity, removing unnecessary usage
of `given/when`, which helps reduce complexity throughout
the codebase.

In the OpenWeatherMapAPI module, the logic for handling
weather response data was streamlined by removing `given/when`
statements in favor of `if` conditions. This change avoids
potential confusion and enhances the clarity of the code logic.
No breaking changes were introduced; the overall functionality
remains intact.
2025-10-14 07:03:38 +02:00
d313cb8d4a Refactor language handling to improve readability
Improved the language initialization logic by replacing the
experimental `given/when` construct with a more standard
`if/elsif` structure, enhancing code readability and
maintainability. Additionally, the attribute handling in the
`Attr` subroutine was refactored for clarity, removing
unnecessary usage of `given/when`, which helps reduce
complexity across the codebase.

Furthermore, in the OpenWeatherMapAPI module, logic for
handling weather response data was streamlined by removing
the `given/when` statements in favor of `if` conditions.
This change eliminates potential confusion and enhances
the clarity of the code logic. No breaking changes were
introduced; the overall functionality remains intact.
2025-10-14 07:01:07 +02:00
2e3210c438 Refactor language initialization and attribute handling
Improved the language initialization logic by replacing
the experimental `given/when` construct with a more
standard `if/elsif` structure. This change enhances code
readability and maintainability, making it easier to follow
the flow of language assignments.

Additionally, refactored attribute handling in the `Attr`
subroutine by streamlining the conditions, removing
unnecessary `given/when` usage, and maintaining clarity
in the logic for setting and deleting forecasts and alerts.
These changes help reduce complexity and improve
consistency throughout the codebase.
2025-10-14 06:53:44 +02:00
2db8db3b89 Merge pull request 'dev' (#75) from dev into main
Reviewed-on: #75
2025-02-05 06:15:30 +00:00
af36bed895 Merge pull request 'patch-removedarksky' (#74) from patch-removedarksky into dev
Reviewed-on: #74
2025-02-05 06:11:46 +00:00
ba898624c5 ```
Refactor pre-commit hook by removing DarkSkyAPI references

Updated the pre-commit hook to eliminate references to
'lib/FHEM/APIs/Weather/DarkSkyAPI.pm'. This change was made to
simplify the codebase and make it more relevant by focusing on
the other weather API files.

Additionally, the output formatting of the pre-commit hook
has been improved for better readability, and the order of
the files in the @filenames array has been restructured for
clarity.

No breaking changes have been introduced; the pre-commit
hook continues to operate as intended.
```
2025-02-05 07:08:45 +01:00
12595b3674 ```
Refactor pre-commit hook file list and output formatting

Updated the list of files in the pre-commit hook to remove
references to 'lib/FHEM/APIs/Weather/DarkSkyAPI.pm' and adjusted
the output formatting for better readability. The order of the
files in the @filenames array has been restructured for clarity.
These changes were necessary to ensure our code base focuses on
the more relevant weather API files.

No breaking changes introduced; the pre-commit hook continues to
function as intended.
```
2025-02-05 07:07:52 +01:00
f7234b10f8 Merge pull request 'dev' (#73) from dev into main
Reviewed-on: #73
2025-02-04 20:30:22 +00:00
be3fb7bbfc Merge pull request 'patch-Unbalanced_p' (#72) from patch-Unbalanced_p into dev
Reviewed-on: #72
2025-02-04 20:29:19 +00:00
23bbc9f9b0 docs: add changelog 2025-02-04 21:27:10 +01:00
e60509fbfd docs: fix unbalanced p 2025-02-04 21:26:52 +01:00
aafeea4d5f Merge pull request 'testing' (#71) from testing into main
Reviewed-on: #71
2025-02-04 20:08:10 +00:00
c6b6a12e47 Merge pull request 'dev' (#70) from dev into testing
Reviewed-on: #70
2025-02-04 20:03:28 +00:00
b57f538bc3 Merge pull request 'patch-changeVersion' (#69) from patch-changeVersion into dev
Reviewed-on: #69
2025-02-04 20:02:15 +00:00
464ba0bec3 docs: add changelog 2025-02-04 21:01:33 +01:00
2b96be4e6e feat: remove DarkSky, change versions
remove DarkSkyAPI, no longer supported
change Copyright years and versions of OWM API

[Ticket: no]
2025-02-04 21:01:17 +01:00
d07297bcd8 Merge pull request 'patch-stefanru' (#68) from patch-stefanru into dev
Reviewed-on: #68
2025-02-04 19:54:21 +00:00
af786290bc docs: changelog
[Ticket: no]
2025-02-04 20:53:14 +01:00
478c4a3159 fix: apply patch from stefanru
https://forum.fhem.de/index.php?msg=1332884

[Ticket: no]
2025-02-04 20:52:52 +01:00
6a38b446a9 Merge pull request 'testing' (#67) from testing into main
Reviewed-on: #67
2024-10-11 17:43:20 +00:00
00c0a2a87e Merge pull request 'dev' (#66) from dev into testing
Reviewed-on: #66
2024-10-11 10:14:14 +00:00
0a47226436 Merge pull request 'patch-fixforecast' (#65) from patch-fixforecast into dev
Reviewed-on: #65
2024-10-11 10:05:05 +00:00
e9fb9357a9 docs: new CHANGELOG 2024-10-11 12:04:37 +02:00
ce875a8beb docs: change versions and add copyright 2024-10-11 12:04:07 +02:00
d0157fb2c7 Merge pull request 'docs: Changelog' (#64) from patch-fixforecast into dev
Reviewed-on: #64
2024-10-11 05:08:47 +00:00
eb134a19e9 docs: Changelog
[Ticket: no]
2024-10-11 07:07:57 +02:00
cfd255569f Merge pull request 'patch-fixforecast' (#63) from patch-fixforecast into dev
Reviewed-on: #63
2024-10-11 05:04:17 +00:00
b1de4b52da fix: Update forecast with cachemaxage after API calls are down.
special thanks to stefanru (forum)

[Ticket: no]
2024-10-11 06:59:53 +02:00
6b6c066a9b Merge pull request 'testing' (#62) from testing into main
Reviewed-on: #62
2023-10-21 09:07:57 +02:00
530fc01d57 Merge pull request 'dev' (#61) from dev into testing
Reviewed-on: #61
2023-10-21 09:07:21 +02:00
7d7cbef4ed Merge pull request 'patch-createDecimal' (#60) from patch-createDecimal into dev
Reviewed-on: #60
2023-10-21 09:00:46 +02:00
8b9bbd4f98 test: add new CHANGELOG 2023-10-21 08:59:11 +02:00
2a06821252 feat: new reading owmAPICode for original code
[Ticket: no]
2023-07-11 14:10:13 +02:00
9868f74a86 Merge pull request 'testing' (#59) from testing into main
Reviewed-on: #59
2023-06-06 08:44:06 +02:00
d2e93a6d5a Merge pull request 'dev' (#58) from dev into testing
Reviewed-on: #58
2023-06-06 08:43:34 +02:00
c27d51534c Merge pull request 'closes #56 patch-newsummaryfield' (#57) from patch-newsummaryfield into dev
Reviewed-on: #57
2023-06-06 08:37:44 +02:00
5bfd1c49d9 feat: add human-readable text of daily forecast
add the proper human-readable text description of the daily forecast

[Ticket: no]
2023-06-06 08:35:06 +02:00
0f1af75a9e Merge pull request 'testing' (#55) from testing into main
Reviewed-on: #55
2023-06-02 05:01:51 +02:00
70a402f096 Merge pull request 'dev' (#54) from dev into testing
Reviewed-on: #54
2023-06-02 05:01:27 +02:00
245fc455e1 Merge pull request 'patch-wunderground' (#53) from patch-wunderground into dev
Reviewed-on: #53
2023-06-02 05:00:55 +02:00
1683fab2d4 add temperatur reading and fix weblink 2023-05-23 08:08:42 +02:00
33763032c6 Merge pull request 'testing' (#52) from testing into main
Reviewed-on: #52
2023-02-05 09:48:33 +01:00
2afb98f9b9 Merge pull request 'dev' (#51) from dev into testing
Reviewed-on: #51
2023-02-05 09:46:46 +01:00
38091aacd1 Merge pull request 'fix: missing perl modules' (#50) from patch-removePrivatFnDeklaration into dev
Reviewed-on: #50
2023-02-05 09:27:02 +01:00
30dd03cbea fix: missing perl modules 2023-02-05 09:26:04 +01:00
43e3fcb237 Merge pull request 'patch-removePrivatFnDeklaration' (#49) from patch-removePrivatFnDeklaration into dev
Reviewed-on: #49
2023-02-05 09:21:27 +01:00
5f611555e3 fix: failed then Readonly is missing 2023-02-05 09:20:20 +01:00
a3fa194cdd Merge pull request 'dev' (#48) from dev into main
Reviewed-on: #48
2023-02-02 23:01:37 +01:00
baa48a79a4 fixes: #46 Merge pull request 'fixes: #46 patch-UndefinedSubroutine' (#47) from patch-UndefinedSubroutine into dev
Reviewed-on: #47
2023-02-02 23:00:17 +01:00