marko/pspmigrator
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add TODOs for using 1st party libraries from k8s

Browse Source
This commit is contained in:
Sam Stoelinga 2022-07-22 06:53:06 -07:00
parent 9107cb0aa2
commit 0c1c6712fa
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pspmutating.go
View File

@ -29,6 +29,7 @@ import (
)
func GetContainerSecurityContexts(podSpec v1.PodSpec) []*v1.SecurityContext {
// TODO reuse VisitContainers from k8s pkg/api/pod/util.go
scs := make([]*v1.SecurityContext, 0)
for _, c := range podSpec.Containers {
scs = append(scs, c.SecurityContext)
@ -82,6 +83,7 @@ func IsPodBeingMutatedByPSP(pod *v1.Pod, clientset *kubernetes.Clientset) (mutat
if owner.Kind == "Node" {
return false, diff, fmt.Errorf("Pod with ownerReference of kind Node is not supported. OwnerReference of pod %v was %#v", pod.Name, owner)
}
// TODO investigate if 1st party library can be used such as github.com/google/go-cmp or smth from k8s
if diffNew := deep.Equal(GetContainerSecurityContexts(parentPod.Spec), GetContainerSecurityContexts(pod.Spec)); diffNew != nil {
diff = append(diff, diffNew...)
}