From 63cf075fd79aaac20b195952a40634f6e8cbfcb4 Mon Sep 17 00:00:00 2001
From: marcel-dempers <aimvec@gmail.com>
Date: Tue, 10 Nov 2020 18:40:23 +1100
Subject: [PATCH] helm wip

---
 kubernetes/helm/README.md                                   | 6 ++++--
 .../{example-app.values.yaml => example-app-01.values.yaml} | 6 +++---
 kubernetes/helm/example-app/example-app-02.values.yaml      | 6 +++---
 kubernetes/helm/example-app/example-app-03.values.yaml      | 6 +++---
 kubernetes/helm/example-app/templates/configmap.yaml        | 2 +-
 kubernetes/helm/example-app/templates/deployment.yaml       | 4 ++--
 6 files changed, 16 insertions(+), 14 deletions(-)
 rename kubernetes/helm/example-app/{example-app.values.yaml => example-app-01.values.yaml} (96%)

diff --git a/kubernetes/helm/README.md b/kubernetes/helm/README.md
index d807f61..8a722b7 100644
--- a/kubernetes/helm/README.md
+++ b/kubernetes/helm/README.md
@@ -47,6 +47,8 @@ chmod +x /usr/local/bin/helm
 
 ## Create our first Chart
 
+For reference in the rest of the guide, I have left my full templates in: <br/>
+`<GitRepo>/kubernetes/helm/example-app`
 ```
 cd kubernetes/helm
 
@@ -157,7 +159,7 @@ spec:
 
 # rollout the change
 
-helm upgrade example-app example-app --values ./example-app/example-app.values.yaml
+helm upgrade example-app example-app --values ./example-app/example-app-01.values.yaml
 ```
 
 ## If\Else and Default values
@@ -199,5 +201,5 @@ This may help you keep the `values.yaml` file small <br/>
 
 # rollout the change
 
-helm upgrade example-app example-app --values ./example-app/example-app.values.yaml
+helm upgrade example-app example-app --values ./example-app/example-app-01.values.yaml
 ```
\ No newline at end of file
diff --git a/kubernetes/helm/example-app/example-app.values.yaml b/kubernetes/helm/example-app/example-app-01.values.yaml
similarity index 96%
rename from kubernetes/helm/example-app/example-app.values.yaml
rename to kubernetes/helm/example-app/example-app-01.values.yaml
index 14752b4..2f3c71d 100644
--- a/kubernetes/helm/example-app/example-app.values.yaml
+++ b/kubernetes/helm/example-app/example-app-01.values.yaml
@@ -1,4 +1,4 @@
-deployment:
-  image: "aimvector/python"
-  tag: "1.0.4"
+deployment:
+  image: "aimvector/python"
+  tag: "1.0.4"
 name: example-app
\ No newline at end of file
diff --git a/kubernetes/helm/example-app/example-app-02.values.yaml b/kubernetes/helm/example-app/example-app-02.values.yaml
index 8a6fbf9..32ada8b 100644
--- a/kubernetes/helm/example-app/example-app-02.values.yaml
+++ b/kubernetes/helm/example-app/example-app-02.values.yaml
@@ -1,4 +1,4 @@
-deployment:
-  image: "aimvector/python"
-  tag: "1.0.4"
+deployment:
+  image: "aimvector/python"
+  tag: "1.0.4"
 name: example-app-2
\ No newline at end of file
diff --git a/kubernetes/helm/example-app/example-app-03.values.yaml b/kubernetes/helm/example-app/example-app-03.values.yaml
index 56d90cf..a89493d 100644
--- a/kubernetes/helm/example-app/example-app-03.values.yaml
+++ b/kubernetes/helm/example-app/example-app-03.values.yaml
@@ -1,4 +1,4 @@
-deployment:
-  image: "aimvector/python"
-  tag: "1.0.4"
+deployment:
+  image: "aimvector/python"
+  tag: "1.0.4"
 name: example-app-3
\ No newline at end of file
diff --git a/kubernetes/helm/example-app/templates/configmap.yaml b/kubernetes/helm/example-app/templates/configmap.yaml
index 38b3030..bd26a95 100644
--- a/kubernetes/helm/example-app/templates/configmap.yaml
+++ b/kubernetes/helm/example-app/templates/configmap.yaml
@@ -5,6 +5,6 @@ metadata:
 data:
   config.json: |
     {
-      "environment" : "prod-1"
+      "environment" : "dev"
     }
 # kubectl create configmap example-config --from-file ./golang/configs/config.json
diff --git a/kubernetes/helm/example-app/templates/deployment.yaml b/kubernetes/helm/example-app/templates/deployment.yaml
index 9a74960..da55125 100644
--- a/kubernetes/helm/example-app/templates/deployment.yaml
+++ b/kubernetes/helm/example-app/templates/deployment.yaml
@@ -24,7 +24,7 @@ spec:
     spec:
       containers:
       - name: "{{ .Values.name }}"
-        image: "{{ .Values.deployment.image }}:{{ .Values.deployment.tag }}"
+        image: {{ .Values.deployment.image }}:{{ .Values.deployment.tag }}
         imagePullPolicy: Always
         ports:
         - containerPort: 5000
@@ -56,4 +56,4 @@ spec:
           limits:
             memory: "1024Mi"
             cpu: "1"
-        {{- end}}
+        {{- end}}