From b1de4b52daec3c9b677c1c1e1e65ec234e2adb5c Mon Sep 17 00:00:00 2001 From: Marko Oldenburg Date: Fri, 11 Oct 2024 06:59:53 +0200 Subject: [PATCH 1/4] fix: Update forecast with cachemaxage after API calls are down. special thanks to stefanru (forum) [Ticket: no] --- CHANGELOG.md | 12 +- controls_Weather.txt | 4 +- lib/FHEM/APIs/Weather/wundergroundAPI.pm | 161 +++++++++++++---------- lib/FHEM/Core/Weather.pm | 1 + 4 files changed, 107 insertions(+), 71 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5cacf2e..ada5bd1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,14 @@ -### feat: new reading owmAPICode for original code (HEAD -> patch-createDecimal) +### test: add new CHANGELOG (HEAD -> patch-createDecimal) +>Sat, 21 Oct 2023 08:59:11 +0200 + +>Author: Marko Oldenburg (fhemdevelopment@cooltux.net) + +>Commiter: Marko Oldenburg (fhemdevelopment@cooltux.net) + + + + +### feat: new reading owmAPICode for original code (origin/patch-createDecimal) >Tue, 11 Jul 2023 14:10:13 +0200 >Author: Marko Oldenburg (fhemdevelopment@cooltux.net) diff --git a/controls_Weather.txt b/controls_Weather.txt index f54136f..d6499c9 100644 --- a/controls_Weather.txt +++ b/controls_Weather.txt @@ -1,5 +1,5 @@ UPD 2023-01-29_16:14:48 25809 FHEM/59_Weather.pm -UPD 2023-06-06_07:31:00 34254 lib/FHEM/Core/Weather.pm +UPD 2024-10-11_06:52:17 34293 lib/FHEM/Core/Weather.pm UPD 2023-01-29_16:14:48 50106 lib/FHEM/APIs/Weather/DarkSkyAPI.pm UPD 2023-07-11_14:08:00 33779 lib/FHEM/APIs/Weather/OpenWeatherMapAPI.pm -UPD 2023-06-02_05:03:58 36607 lib/FHEM/APIs/Weather/wundergroundAPI.pm +UPD 2024-10-11_06:49:47 37627 lib/FHEM/APIs/Weather/wundergroundAPI.pm diff --git a/lib/FHEM/APIs/Weather/wundergroundAPI.pm b/lib/FHEM/APIs/Weather/wundergroundAPI.pm index 32a23cd..35e6163 100644 --- a/lib/FHEM/APIs/Weather/wundergroundAPI.pm +++ b/lib/FHEM/APIs/Weather/wundergroundAPI.pm @@ -15,9 +15,9 @@ return "$@" if ($@); return $ret if ($ret); $::packages{wundergroundAPI}{META} = $META; -use version 0.77; our $VERSION = $META->{version}; +use version 0.80; our $VERSION = $META->{version}; -# use Data::Dumper; +use Data::Dumper; # try to use JSON::MaybeXS wrapper # for chance of better performance + open code @@ -103,10 +103,11 @@ sub new { ? $argsRef->{apikey} : 'none' ), - lang => $argsRef->{language}, - lat => ( split( ',', $argsRef->{location} ) )[0], - long => ( split( ',', $argsRef->{location} ) )[1], - fetchTime => 0, + lang => $argsRef->{language}, + lat => ( split( ',', $argsRef->{location} ) )[0], + long => ( split( ',', $argsRef->{location} ) )[1], + fetchTime => 0, + forecastFetchTime => 0, }; $self->{cachemaxage} = ( @@ -210,29 +211,66 @@ sub _RetrieveDataFromWU { return 0 unless ( __PACKAGE__ eq caller(0) ); my $self = shift; - - # retrieve data from cache - if ( ( time() - $self->{fetchTime} ) < $self->{cachemaxage} - and $self->{cached}->{lat} == $self->{lat} - and $self->{cached}->{long} == $self->{long} ) - { - return _CallWeatherCallbackFn($self); - } + my $paramRef; + my $options; $self->{cached}->{lat} = $self->{lat} unless ( $self->{cached}->{lat} == $self->{lat} ); $self->{cached}->{long} = $self->{long} unless ( $self->{cached}->{long} == $self->{long} ); - my $paramRef = { - timeout => 15, - self => $self, - callback => ( - $self->{stationId} - ? \&_RetrieveDataFromPWS - : \&_RetrieveDataFinished - ), - }; + # retrieve forecast data from cache + if ( ( time() - $self->{forecastFetchTime} ) < $self->{cachemaxage} + and $self->{cached}->{lat} == $self->{lat} + and $self->{cached}->{long} == $self->{long} ) + { + # old: return _CallWeatherCallbackFn($self); + # Do not just return but get PWS data without forecast + $paramRef = { + timeout => 15, + self => $self, + callback => \&_RetrieveDataFinished, + }; + + #Build station URL + $options = 'stationId=' . $self->{stationId}; + $options .= '&format=json'; + $options .= '&units=' . $self->{units}; + $options .= '&numericPrecision=decimal'; + $options .= '&apiKey=' . $self->{key}; + + $paramRef->{url} = $URL . 'v2/pws/observations/current?' . $options; + } + else { + # Get the complete data station and forecast + $paramRef = { + timeout => 15, + self => $self, + callback => ( + $self->{stationId} + ? \&_RetrieveDataFromPWS + : \&_RetrieveDataFinished + ), + }; + + # Build forecast URL + $options = 'geocode=' . $self->{lat} . ',' . $self->{long}; + $options .= '&format=json'; + $options .= '&units=' . $self->{units}; + $options .= '&language=' + . ( + $self->{lang} eq 'en' + ? 'en-US' + : $self->{lang} . '-' . uc( $self->{lang} ) + ); + $options .= '&apiKey=' . $self->{key}; + + $paramRef->{url} = + $URL + . 'v3/wx/forecast/daily/' + . $self->{days} . 'day' . '?' + . $options; + } if ( $self->{lat} eq 'error' or $self->{long} eq 'error' @@ -250,23 +288,6 @@ sub _RetrieveDataFromWU { if ( $self->{key} eq 'none' ); } else { - my $options = 'geocode=' . $self->{lat} . ',' . $self->{long}; - $options .= '&format=json'; - $options .= '&units=' . $self->{units}; - $options .= '&language=' - . ( - $self->{lang} eq 'en' - ? 'en-US' - : $self->{lang} . '-' . uc( $self->{lang} ) - ); - $options .= '&apiKey=' . $self->{key}; - - $paramRef->{url} = - $URL - . 'v3/wx/forecast/daily/' - . $self->{days} . 'day' . '?' - . $options; - if ( lc( $self->{key} ) eq 'demo' ) { _RetrieveDataFinished( $paramRef, undef, 'DEMODATA' . $DEMODATA ); } @@ -352,10 +373,20 @@ sub _RetrieveDataFinished { $self->{cached}{status} = 'ok'; $self->{cached}{validity} = 'up-to-date'; $self->{fetchTime} = time(); + + #print Dumper $response; ## for debugging + #print Dumper $data; ## for debugging + #if (exists( $response->{daily} )) { + if ( $response =~ /{"daily":/ ) { + $self->{forecastFetchTime} = time(); + } _ProcessingRetrieveData( $self, $response ); } else { $self->{fetchTime} = time() if ( not defined( $self->{fetchTime} ) ); + $self->{forecastFetchTime} = time() + if ( not defined( $self->{forecastFetchTime} ) ); + _ErrorHandling( $self, $err ); _ProcessingRetrieveData( $self, $response ); } @@ -389,12 +420,15 @@ sub _ProcessingRetrieveData { # 'Code: ' . $data->{code} . ' Error: ' . $data->{error} ); # } else { - # print Dumper $response; ## für Debugging - # print Dumper $data; ## für Debugging + # print Dumper $response; ## for debugging + # print Dumper $data; ## for debugging $self->{cached}{current_date_time} = _strftimeWrapper( "%a, %e %b %Y %H:%M", localtime( $self->{fetchTime} ) ); + $self->{cached}{current_forecast_date_time} = + _strftimeWrapper( "%a, %e %b %Y %H:%M", + localtime( $self->{forecastFetchTime} ) ); # $self->{cached}{timezone} = $data->{timezone}; $self->{cached}{license}{text} = @@ -423,34 +457,22 @@ sub _ProcessingRetrieveData { ); $self->{cached}{current} = { - 'dewPoint' => - int( sprintf( "%.1f", $data->{$unit}{dewpt} ) + 0.5 ), - 'heatIndex' => $data->{$unit}{heatIndex}, + 'dewPoint' => sprintf( "%.1f", $data->{$unit}{dewpt} ), + 'heatIndex' => $data->{$unit}{heatIndex}, 'precipRate' => $data->{$unit}{precipRate}, 'precipTotal' => $data->{$unit}{precipTotal}, - 'pressure' => int( - sprintf( "%.1f", $data->{$unit}{pressure} ) + 0.5 - ), + 'pressure' => + sprintf( "%.1f", $data->{$unit}{pressure} ), 'temperature' => - int( sprintf( "%.1f", $data->{$unit}{temp} ) + 0.5 ), - 'temp_c' => - int( sprintf( "%.1f", $data->{$unit}{temp} ) + 0.5 ), - 'wind_chill' => int( - sprintf( "%.1f", ( $data->{$unit}{windChill} ) ) + - 0.5 - ), - 'windGust' => int( - sprintf( "%.1f", ( $data->{$unit}{windGust} ) ) + - 0.5 - ), - 'wind' => int( - sprintf( "%.1f", ( $data->{$unit}{windSpeed} ) ) + - 0.5 - ), - 'wind_speed' => int( - sprintf( "%.1f", ( $data->{$unit}{windSpeed} ) ) + - 0.5 - ), + sprintf( "%.1f", $data->{$unit}{temp} ), + 'temp_c' => sprintf( "%.1f", $data->{$unit}{temp} ), + 'wind_chill' => + sprintf( "%.1f", $data->{$unit}{windChill} ), + 'windGust' => + sprintf( "%.1f", $data->{$unit}{windGust} ), + 'wind' => sprintf( "%.1f", $data->{$unit}{windSpeed} ), + 'wind_speed' => + sprintf( "%.1f", $data->{$unit}{windSpeed} ), 'wind_direction' => $data->{winddir}, 'solarRadiation' => $data->{solarRadiation}, 'uvIndex' => $data->{uv}, @@ -742,7 +764,7 @@ sub _CallWeatherCallbackFn { my $self = shift; - # ## Aufruf der callbackFn + ## Aufruf der callbackFn return FHEM::Core::Weather::RetrieveCallbackFn( $self->{devName} ); } @@ -754,6 +776,9 @@ sub _ErrorHandling { $self->{cached}{current_date_time} = _strftimeWrapper( "%a, %e %b %Y %H:%M", localtime( $self->{fetchTime} ) ); + $self->{cached}{current_forecast_date_time} = + _strftimeWrapper( "%a, %e %b %Y %H:%M", + localtime( $self->{forecastFetchTime} ) ); $self->{cached}{status} = $err; $self->{cached}{validity} = 'stale'; diff --git a/lib/FHEM/Core/Weather.pm b/lib/FHEM/Core/Weather.pm index 2408121..b6841f6 100644 --- a/lib/FHEM/Core/Weather.pm +++ b/lib/FHEM/Core/Weather.pm @@ -8,6 +8,7 @@ # Contributors: # - Marko Oldenburg (CoolTux) # - Lippie +# - stefanru (wundergroundAPI) # # # This file is part of fhem. -- 2.45.2 From eb134a19e99b873bb10aa063d5c7c0cb3a59c455 Mon Sep 17 00:00:00 2001 From: Marko Oldenburg Date: Fri, 11 Oct 2024 07:07:57 +0200 Subject: [PATCH 2/4] docs: Changelog [Ticket: no] --- CHANGELOG.md | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ada5bd1..6f89553 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,15 @@ -### test: add new CHANGELOG (HEAD -> patch-createDecimal) +### fix: Update forecast with cachemaxage after API calls are down. special thanks to stefanru (forum) (HEAD -> patch-fixforecast) +>Fri, 11 Oct 2024 06:59:53 +0200 + +>Author: Marko Oldenburg (fhemdevelopment@cooltux.net) + +>Commiter: Marko Oldenburg (fhemdevelopment@cooltux.net) + +[Ticket: no] + + + +### test: add new CHANGELOG >Sat, 21 Oct 2023 08:59:11 +0200 >Author: Marko Oldenburg (fhemdevelopment@cooltux.net) @@ -8,7 +19,7 @@ -### feat: new reading owmAPICode for original code (origin/patch-createDecimal) +### feat: new reading owmAPICode for original code >Tue, 11 Jul 2023 14:10:13 +0200 >Author: Marko Oldenburg (fhemdevelopment@cooltux.net) -- 2.45.2 From ce875a8bebf51fb364bdc1adb3db4407bde0936b Mon Sep 17 00:00:00 2001 From: Marko Oldenburg Date: Fri, 11 Oct 2024 12:04:07 +0200 Subject: [PATCH 3/4] docs: change versions and add copyright --- FHEM/59_Weather.pm | 5 +++-- controls_Weather.txt | 6 +++--- lib/FHEM/APIs/Weather/wundergroundAPI.pm | 2 +- lib/FHEM/Core/Weather.pm | 2 +- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/FHEM/59_Weather.pm b/FHEM/59_Weather.pm index b6ca7c5..a7af721 100755 --- a/FHEM/59_Weather.pm +++ b/FHEM/59_Weather.pm @@ -2,12 +2,13 @@ ############################################################################## # # 59_Weather.pm -# (c) 2009-2023 Copyright by Dr. Boris Neubert +# (c) 2009-2024 Copyright by Dr. Boris Neubert # e-mail: omega at online dot de # # Contributors: # - Marko Oldenburg (CoolTux) # - Lippie +# - stefanru (wundergroundAPI) # # # This file is part of fhem. @@ -543,7 +544,7 @@ __END__ ], "release_status": "stable", "license": "GPL_2", - "version": "v2.2.22", + "version": "v2.2.30", "author": [ "Marko Oldenburg " ], diff --git a/controls_Weather.txt b/controls_Weather.txt index d6499c9..74f16bc 100644 --- a/controls_Weather.txt +++ b/controls_Weather.txt @@ -1,5 +1,5 @@ -UPD 2023-01-29_16:14:48 25809 FHEM/59_Weather.pm -UPD 2024-10-11_06:52:17 34293 lib/FHEM/Core/Weather.pm +UPD 2024-10-11_12:02:22 25848 FHEM/59_Weather.pm +UPD 2024-10-11_11:59:21 34293 lib/FHEM/Core/Weather.pm UPD 2023-01-29_16:14:48 50106 lib/FHEM/APIs/Weather/DarkSkyAPI.pm UPD 2023-07-11_14:08:00 33779 lib/FHEM/APIs/Weather/OpenWeatherMapAPI.pm -UPD 2024-10-11_06:49:47 37627 lib/FHEM/APIs/Weather/wundergroundAPI.pm +UPD 2024-10-11_12:02:42 37627 lib/FHEM/APIs/Weather/wundergroundAPI.pm diff --git a/lib/FHEM/APIs/Weather/wundergroundAPI.pm b/lib/FHEM/APIs/Weather/wundergroundAPI.pm index 35e6163..5e51e42 100644 --- a/lib/FHEM/APIs/Weather/wundergroundAPI.pm +++ b/lib/FHEM/APIs/Weather/wundergroundAPI.pm @@ -840,7 +840,7 @@ sub _strftimeWrapper { "abstract": "Wetter API für Weather Underground" } }, - "version": "v1.2.0", + "version": "v1.3.0", "author": [ "Julian Pawlowski " ], diff --git a/lib/FHEM/Core/Weather.pm b/lib/FHEM/Core/Weather.pm index b6841f6..e039981 100644 --- a/lib/FHEM/Core/Weather.pm +++ b/lib/FHEM/Core/Weather.pm @@ -2,7 +2,7 @@ ############################################################################## # # 59_Weather.pm -# (c) 2009-2023 Copyright by Dr. Boris Neubert +# (c) 2009-2024 Copyright by Dr. Boris Neubert # e-mail: omega at online dot de # # Contributors: -- 2.45.2 From e9fb9357a9eb4825bbb4e835619776a29e87249f Mon Sep 17 00:00:00 2001 From: Marko Oldenburg Date: Fri, 11 Oct 2024 12:04:37 +0200 Subject: [PATCH 4/4] docs: new CHANGELOG --- CHANGELOG.md | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6f89553..59e3d91 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,25 @@ -### fix: Update forecast with cachemaxage after API calls are down. special thanks to stefanru (forum) (HEAD -> patch-fixforecast) +### docs: change versions and add copyright (HEAD -> patch-fixforecast) +>Fri, 11 Oct 2024 12:04:07 +0200 + +>Author: Marko Oldenburg (fhemdevelopment@cooltux.net) + +>Commiter: Marko Oldenburg (fhemdevelopment@cooltux.net) + + + + +### docs: Changelog (origin/patch-fixforecast) +>Fri, 11 Oct 2024 07:07:57 +0200 + +>Author: Marko Oldenburg (fhemdevelopment@cooltux.net) + +>Commiter: Marko Oldenburg (fhemdevelopment@cooltux.net) + +[Ticket: no] + + + +### fix: Update forecast with cachemaxage after API calls are down. special thanks to stefanru (forum) >Fri, 11 Oct 2024 06:59:53 +0200 >Author: Marko Oldenburg (fhemdevelopment@cooltux.net) -- 2.45.2