Refactor language handling in Weather API
Improved the language initialization logic by replacing the experimental `given/when` construct with a more standard `if/elsif` structure, enhancing code readability and maintainability. The attribute handling in the `Attr` subroutine was also refactored for clarity, removing unnecessary usage of `given/when`, which helps reduce complexity throughout the codebase. In the OpenWeatherMapAPI module, the logic for handling weather response data was streamlined by removing `given/when` statements in favor of `if` conditions. This change avoids potential confusion and enhances the clarity of the code logic. No breaking changes were introduced; the overall functionality remains intact.
This commit is contained in:
26
CHANGELOG.md
26
CHANGELOG.md
@@ -1,4 +1,28 @@
|
|||||||
### Refactor language initialization and attribute handling (HEAD -> patch-remove-perlexperimental)
|
### Refactor language handling to improve readability (HEAD -> patch-remove-perlexperimental)
|
||||||
|
>Tue, 14 Oct 2025 07:01:07 +0200
|
||||||
|
|
||||||
|
>Author: Marko Oldenburg (fhemdevelopment@cooltux.net)
|
||||||
|
|
||||||
|
>Commiter: Marko Oldenburg (fhemdevelopment@cooltux.net)
|
||||||
|
|
||||||
|
Improved the language initialization logic by replacing the
|
||||||
|
experimental `given/when` construct with a more standard
|
||||||
|
`if/elsif` structure, enhancing code readability and
|
||||||
|
maintainability. Additionally, the attribute handling in the
|
||||||
|
`Attr` subroutine was refactored for clarity, removing
|
||||||
|
unnecessary usage of `given/when`, which helps reduce
|
||||||
|
complexity across the codebase.
|
||||||
|
|
||||||
|
Furthermore, in the OpenWeatherMapAPI module, logic for
|
||||||
|
handling weather response data was streamlined by removing
|
||||||
|
the `given/when` statements in favor of `if` conditions.
|
||||||
|
This change eliminates potential confusion and enhances
|
||||||
|
the clarity of the code logic. No breaking changes were
|
||||||
|
introduced; the overall functionality remains intact.
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
### Refactor language initialization and attribute handling
|
||||||
>Tue, 14 Oct 2025 06:53:44 +0200
|
>Tue, 14 Oct 2025 06:53:44 +0200
|
||||||
|
|
||||||
>Author: Marko Oldenburg (fhemdevelopment@cooltux.net)
|
>Author: Marko Oldenburg (fhemdevelopment@cooltux.net)
|
||||||
|
@@ -1,4 +1,4 @@
|
|||||||
UPD 2025-02-05_05:56:41 25899 FHEM/59_Weather.pm
|
UPD 2025-02-05_05:56:41 25899 FHEM/59_Weather.pm
|
||||||
UPD 2025-10-14_06:51:10 34175 lib/FHEM/Core/Weather.pm
|
UPD 2025-10-14_06:51:10 34175 lib/FHEM/Core/Weather.pm
|
||||||
UPD 2025-10-14_07:00:04 33545 lib/FHEM/APIs/Weather/OpenWeatherMapAPI.pm
|
UPD 2025-10-14_07:00:04 33545 lib/FHEM/APIs/Weather/OpenWeatherMapAPI.pm
|
||||||
UPD 2025-02-04_21:08:26 38751 lib/FHEM/APIs/Weather/wundergroundAPI.pm
|
UPD 2025-10-14_07:03:17 38721 lib/FHEM/APIs/Weather/wundergroundAPI.pm
|
||||||
|
@@ -6,7 +6,6 @@ use FHEM::Meta;
|
|||||||
|
|
||||||
use POSIX;
|
use POSIX;
|
||||||
use HttpUtils;
|
use HttpUtils;
|
||||||
use experimental qw /switch/;
|
|
||||||
use Encode;
|
use Encode;
|
||||||
|
|
||||||
my $META = {};
|
my $META = {};
|
||||||
|
Reference in New Issue
Block a user