From 30dd03cbea6351c2667da37ed58d13709fa80e7d Mon Sep 17 00:00:00 2001
From: Marko Oldenburg <fhemdevelopment@cooltux.net>
Date: Sun, 5 Feb 2023 09:26:04 +0100
Subject: [PATCH] fix: missing perl modules

---
 controls_Weather.txt     | 2 +-
 lib/FHEM/Core/Weather.pm | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/controls_Weather.txt b/controls_Weather.txt
index 6eed585..1dfe74d 100644
--- a/controls_Weather.txt
+++ b/controls_Weather.txt
@@ -1,5 +1,5 @@
 UPD 2023-01-29_16:14:48 25809 FHEM/59_Weather.pm
-UPD 2023-02-05_09:19:03 34095 lib/FHEM/Core/Weather.pm
+UPD 2023-02-05_09:25:24 34254 lib/FHEM/Core/Weather.pm
 UPD 2023-01-29_16:14:48 50106 lib/FHEM/APIs/Weather/DarkSkyAPI.pm
 UPD 2023-01-29_16:14:48 33422 lib/FHEM/APIs/Weather/OpenWeatherMapAPI.pm
 UPD 2023-01-29_16:14:48 36101 lib/FHEM/APIs/Weather/wundergroundAPI.pm
diff --git a/lib/FHEM/Core/Weather.pm b/lib/FHEM/Core/Weather.pm
index f1454e7..2408121 100644
--- a/lib/FHEM/Core/Weather.pm
+++ b/lib/FHEM/Core/Weather.pm
@@ -32,7 +32,7 @@ package FHEM::Core::Weather;
 use strict;
 use warnings;
 
-my $missingModul = 'apt install';
+my $missingModul = '';
 
 eval { use Time::HiRes qw /gettimeofday/; 1 }
   or $missingModul .= "libtime-hires-perl ";
@@ -777,6 +777,12 @@ sub Define {
     return $@ unless ( FHEM::Meta::SetInternals($hash) );
     use version 0.60; our $VERSION = FHEM::Meta::Get( $hash, 'version' );
 
+    return
+        'Cannot define Weather device. Please use "apt install '
+      . ${missingModul}
+      . ' to install missing perl modules'
+      if ($missingModul);
+
     my $usage =
 "syntax: define <name> Weather [API=<API>] [apikey=<apikey>] [location=<location>] [interval=<interval>] [lang=<lang>]";