From b0a0d8fa9954fed79bc8a6cf645df3b9f0105f8c Mon Sep 17 00:00:00 2001 From: Marko Oldenburg Date: Sun, 13 Mar 2022 07:26:24 +0100 Subject: [PATCH 1/2] fix uninitialized value fix uninitialized value in string eq at fhem.pl line 4962 [Ticket: #6] --- FHEM/82_LGTV_WebOS.pm | 2 +- controls_LGTV_WebOS.txt | 4 ++-- lib/FHEM/Devices/LGTV/LGTVWebOS.pm | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/FHEM/82_LGTV_WebOS.pm b/FHEM/82_LGTV_WebOS.pm index e4911f4..d129a2a 100644 --- a/FHEM/82_LGTV_WebOS.pm +++ b/FHEM/82_LGTV_WebOS.pm @@ -368,7 +368,7 @@ __END__ ], "release_status": "stable", "license": "GPL_2", - "version": "v3.6.1", + "version": "v3.6.2", "author": [ "Marko Oldenburg " ], diff --git a/controls_LGTV_WebOS.txt b/controls_LGTV_WebOS.txt index 4e941b5..2eff3bd 100644 --- a/controls_LGTV_WebOS.txt +++ b/controls_LGTV_WebOS.txt @@ -1,2 +1,2 @@ -UPD 2022-03-10_09:40:57 18968 FHEM/82_LGTV_WebOS.pm -UPD 2022-03-10_09:28:02 54278 lib/FHEM/Devices/LGTV/LGTVWebOS.pm +UPD 2022-03-13_07:23:31 18968 FHEM/82_LGTV_WebOS.pm +UPD 2022-03-13_07:23:19 54336 lib/FHEM/Devices/LGTV/LGTVWebOS.pm diff --git a/lib/FHEM/Devices/LGTV/LGTVWebOS.pm b/lib/FHEM/Devices/LGTV/LGTVWebOS.pm index 79cbbec..8448352 100644 --- a/lib/FHEM/Devices/LGTV/LGTVWebOS.pm +++ b/lib/FHEM/Devices/LGTV/LGTVWebOS.pm @@ -1288,7 +1288,8 @@ sub WriteReadings { if ( exists( $decode_json->{payload}{'channelName'} ) ); ::readingsBulkUpdateIfChanged( $hash, 'channelMedia', $decode_json->{payload}{'channelTypeName'} ) - if ( exists( $decode_json->{payload}{'channelTypeName'} ) ); + if ( exists( $decode_json->{payload}{'channelTypeName'} ) + && $decode_json->{payload}{'channelTypeName'} ); } else { From fee3cf2d001f1dd167be3a1ced979ff34ef1eb86 Mon Sep 17 00:00:00 2001 From: Marko Oldenburg Date: Sun, 13 Mar 2022 11:14:31 +0100 Subject: [PATCH 2/2] fix --- controls_LGTV_WebOS.txt | 4 ++-- lib/FHEM/Devices/LGTV/LGTVWebOS.pm | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/controls_LGTV_WebOS.txt b/controls_LGTV_WebOS.txt index 2eff3bd..3163361 100644 --- a/controls_LGTV_WebOS.txt +++ b/controls_LGTV_WebOS.txt @@ -1,2 +1,2 @@ -UPD 2022-03-13_07:23:31 18968 FHEM/82_LGTV_WebOS.pm -UPD 2022-03-13_07:23:19 54336 lib/FHEM/Devices/LGTV/LGTVWebOS.pm +UPD 2022-03-13_11:13:55 18968 FHEM/82_LGTV_WebOS.pm +UPD 2022-03-13_11:13:52 54282 lib/FHEM/Devices/LGTV/LGTVWebOS.pm diff --git a/lib/FHEM/Devices/LGTV/LGTVWebOS.pm b/lib/FHEM/Devices/LGTV/LGTVWebOS.pm index 8448352..e39e970 100644 --- a/lib/FHEM/Devices/LGTV/LGTVWebOS.pm +++ b/lib/FHEM/Devices/LGTV/LGTVWebOS.pm @@ -361,7 +361,7 @@ sub TimerStatusRequest { } else { - ::readingsSingleUpdate( $hash, 'state', 'off', 1 ) + ::readingsBulkUpdateIfChanged( $hash, 'state', 'off' ) if ( ::ReadingsVal( $name, 'state', 'off' ) ne 'off' ); Presence($hash) @@ -1288,8 +1288,7 @@ sub WriteReadings { if ( exists( $decode_json->{payload}{'channelName'} ) ); ::readingsBulkUpdateIfChanged( $hash, 'channelMedia', $decode_json->{payload}{'channelTypeName'} ) - if ( exists( $decode_json->{payload}{'channelTypeName'} ) - && $decode_json->{payload}{'channelTypeName'} ); + if ( exists( $decode_json->{payload}{'channelTypeName'} ) ); } else {