From b7adf6af6d9952bace55faf56d8452bb6503e47b Mon Sep 17 00:00:00 2001
From: Sebastian <em@ail.tld>
Date: Sat, 7 May 2022 12:58:03 +0200
Subject: [PATCH] add readingss and fix payload

---
 CHANGED                         |  2 +-
 FHEM/74_GardenaSmartDevice.pm   | 16 ++++++++++++----
 controls_GardenaSmartDevice.txt |  4 ++--
 3 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/CHANGED b/CHANGED
index b400eb8..242c969 100644
--- a/CHANGED
+++ b/CHANGED
@@ -1 +1 @@
-    operatingmode, leakagedetection and turnonpressure fix - ins blaue gerate
+    more debug
diff --git a/FHEM/74_GardenaSmartDevice.pm b/FHEM/74_GardenaSmartDevice.pm
index ec7941d..02add3e 100644
--- a/FHEM/74_GardenaSmartDevice.pm
+++ b/FHEM/74_GardenaSmartDevice.pm
@@ -488,7 +488,7 @@ sub Set {
       $payload = '"name":"operating_mode"'
                  .'"value":"'.$op_mode.'"'
                  .'"device":"'
-                 . $hash->{DEVICEID};
+                 . $hash->{DEVICEID}.'"';
       $abilities = 'watering_pressure_pump_settings';
       $service_id = $hash->{helper}->{ 'operating_mode_id' };
     }
@@ -497,7 +497,7 @@ sub Set {
       $payload = '"name":"leakage_detection"'
                  .'"value":"'.$leakdetection_mode.'"'
                  .'"device":"'
-                 . $hash->{DEVICEID};
+                 . $hash->{DEVICEID}.'"';
       $abilities = 'watering_pressure_pump_settings';
       $service_id = $hash->{helper}->{ 'leakage_detection_id' };
     }
@@ -506,7 +506,7 @@ sub Set {
       $payload = '"name":"turn_on_pressure"'
                  .'"value":"'.$turnonpressure.'"'
                  .'"device":"'
-                 . $hash->{DEVICEID};
+                 . $hash->{DEVICEID}.'"';
       $abilities = 'watering_pressure_pump_settings';
       $service_id = $hash->{helper}->{ 'turn_on_pressure_id' };
     }
@@ -562,7 +562,7 @@ sub Set {
 'closeAllValves:noArg stopScheduleValve:selectnumbers,1,1,6,0,lin resumeScheduleValve:selectnumbers,1,1,6,0,lin manualDurationValve1:slider,1,1,90 manualDurationValve2:slider,1,1,90 manualDurationValve3:slider,1,1,90 manualDurationValve4:slider,1,1,90 manualDurationValve5:slider,1,1,90 manualDurationValve6:slider,1,1,90 cancelOverrideValve1:noArg cancelOverrideValve2:noArg cancelOverrideValve3:noArg cancelOverrideValve4:noArg cancelOverrideValve5:noArg cancelOverrideValve6:noArg'
           if ( AttrVal( $name, 'model', 'unknown' ) eq 'ic24' );
 
-        $list .= 'manualOverride:slider,1,1,90 cancelOverride:noArg operatingMode:automatic,scheduled leakageDetection:watering,washing_machine,domestic_water_supply,off turnOnpressure:slider,2,0.2,2.8,1'
+        $list .= 'manualOverride:slider,1,1,90 cancelOverride:noArg operatingMode:automatic,scheduled leakageDetection:watering,washing_machine,domestic_water_supply,off turnOnpressure:slider,2,0.2,3.0,1'
           if ( AttrVal( $name, 'model', 'unknown' ) eq 'electronic_pressure_pump' );
 
         $list .= 'refresh:temperature,humidity'
@@ -817,6 +817,14 @@ sub WriteReadings {
                     $decode_json->{settings}[$settings]{value} );
             }
 
+            # save electroni presse pump settings as readings
+            if ( $decode_json->{settings}[$settings]{name} eq 'operating_mode' 
+                || $decode_json->{settings}[$settings]{name} eq 'leakage_detection' 
+                || $decode_json->{settings}[$settings]{name} eq 'turn_on_pressure' ) {
+                readingsBulkUpdateIfChanged( $hash, $decode_json->{settings}[$settings]{name},
+                    $decode_json->{settings}[$settings]{value} );
+
+            }
             # save winter mode as reading
 
             if ( $decode_json->{settings}[$settings]{name} eq 'winter_mode' ) {
diff --git a/controls_GardenaSmartDevice.txt b/controls_GardenaSmartDevice.txt
index 70b68f1..dedce96 100644
--- a/controls_GardenaSmartDevice.txt
+++ b/controls_GardenaSmartDevice.txt
@@ -1,2 +1,2 @@
-UPD 2022-05-06_18:56:40 49518 FHEM/73_GardenaSmartBridge.pm
-UPD 2022-05-06_18:53:25 63165 FHEM/74_GardenaSmartDevice.pm
+UPD 2022-05-07_12:43:24 49518 FHEM/73_GardenaSmartBridge.pm
+UPD 2022-05-07_12:57:29 63667 FHEM/74_GardenaSmartDevice.pm