From ab026bdc1b6e00b4280557d0c432928e8a2a3bf6 Mon Sep 17 00:00:00 2001 From: Marko Oldenburg Date: Thu, 28 Sep 2017 07:52:28 +0200 Subject: [PATCH] add disabledForInterval syntax check and Interval Value greater than 0 --- 73_GardenaSmartBridge.pm | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/73_GardenaSmartBridge.pm b/73_GardenaSmartBridge.pm index 6bf842d..0d2d682 100644 --- a/73_GardenaSmartBridge.pm +++ b/73_GardenaSmartBridge.pm @@ -68,7 +68,7 @@ eval "use JSON;1" or $missingModul .= "JSON "; eval "use IO::Socket::SSL;1" or $missingModul .= "IO::Socket::SSL "; -my $version = "0.2.5"; +my $version = "0.2.6"; @@ -208,9 +208,12 @@ sub GardenaSmartBridge_Attr(@) { } elsif( $attrName eq "disabledForIntervals" ) { + #return "check disabledForIntervals Syntax HH:MM-HH:MM or 'HH:MM-HH:MM HH:MM-HH:MM ...'" + #unless($attrVal =~ /^((\d{2}:\d{2})-(\d{2}:\d{2})\s?)+$/); if( $cmd eq "set" ) { + return "check disabledForIntervals Syntax HH:MM-HH:MM or 'HH:MM-HH:MM HH:MM-HH:MM ...'" + unless($attrVal =~ /^((\d{2}:\d{2})-(\d{2}:\d{2})\s?)+$/); Log3 $name, 3, "GardenaSmartBridge ($name) - disabledForIntervals"; - readingsSingleUpdate ( $hash, "state", "inactive", 1 ); } elsif( $cmd eq "del" ) { @@ -221,6 +224,8 @@ sub GardenaSmartBridge_Attr(@) { elsif( $attrName eq "interval" ) { if( $cmd eq "set" ) { + return "Interval must be greater than 0" + unless($attrVal > 0); $hash->{INTERVAL} = $attrVal; RemoveInternalTimer($hash); Log3 $name, 3, "GardenaSmartBridge ($name) - set interval: $attrVal";