From 4e52ea82150655bbd8393d3c374b73c9437484cc Mon Sep 17 00:00:00 2001 From: Sebastian Date: Mon, 12 Jul 2021 12:01:02 +0200 Subject: [PATCH 1/3] add payload propertie --- FHEM/74_GardenaSmartDevice.pm | 2 +- controls_GardenaSmartDevice.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/FHEM/74_GardenaSmartDevice.pm b/FHEM/74_GardenaSmartDevice.pm index ce951a6..d2bf554 100644 --- a/FHEM/74_GardenaSmartDevice.pm +++ b/FHEM/74_GardenaSmartDevice.pm @@ -412,7 +412,7 @@ sub Set { : lc $cmd ); - $payload = '"properties":{"value":"' . $val . '"}'; + $payload = '"properties":{"name":"power_timer", "value":"' . $val . '"}'; } ### Watering ic24 elsif ( $cmd =~ m{\AmanualDurationValve\d\z}xms ) { diff --git a/controls_GardenaSmartDevice.txt b/controls_GardenaSmartDevice.txt index 852aaca..3ab01be 100644 --- a/controls_GardenaSmartDevice.txt +++ b/controls_GardenaSmartDevice.txt @@ -1,2 +1,2 @@ UPD 2021-06-28_15:56:58 47009 FHEM/73_GardenaSmartBridge.pm -UPD 2021-06-28_20:08:52 56188 FHEM/74_GardenaSmartDevice.pm +UPD 2021-07-12_11:56:06 56210 FHEM/74_GardenaSmartDevice.pm From a856bb574a03ec70b124cf1fd5c2a815fdeed499 Mon Sep 17 00:00:00 2001 From: Sebastian Date: Tue, 13 Jul 2021 17:22:03 +0200 Subject: [PATCH 2/3] fix empty arg array condition --- FHEM/74_GardenaSmartDevice.pm | 2 +- controls_GardenaSmartDevice.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/FHEM/74_GardenaSmartDevice.pm b/FHEM/74_GardenaSmartDevice.pm index d2bf554..db63b3a 100644 --- a/FHEM/74_GardenaSmartDevice.pm +++ b/FHEM/74_GardenaSmartDevice.pm @@ -407,7 +407,7 @@ sub Set { } elsif ( lc $cmd eq 'on' || lc $cmd eq 'off' || lc $cmd eq 'on-for-timer' ) { my $val = ( - defined($aArg) && ref($aArg) eq 'ARRAY' + scalar(!@$aArg == 0) && ref($aArg) eq 'ARRAY' ? $aArg->[0] * 60 : lc $cmd ); diff --git a/controls_GardenaSmartDevice.txt b/controls_GardenaSmartDevice.txt index 3ab01be..4507d86 100644 --- a/controls_GardenaSmartDevice.txt +++ b/controls_GardenaSmartDevice.txt @@ -1,2 +1,2 @@ UPD 2021-06-28_15:56:58 47009 FHEM/73_GardenaSmartBridge.pm -UPD 2021-07-12_11:56:06 56210 FHEM/74_GardenaSmartDevice.pm +UPD 2021-07-13_17:21:48 56216 FHEM/74_GardenaSmartDevice.pm From 12c4a0d5ba69273153e04593ab8e5257a641e0b6 Mon Sep 17 00:00:00 2001 From: Sebastian Date: Fri, 16 Jul 2021 20:26:16 +0200 Subject: [PATCH 3/3] increase slider to 720 --- FHEM/74_GardenaSmartDevice.pm | 2 +- controls_GardenaSmartDevice.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/FHEM/74_GardenaSmartDevice.pm b/FHEM/74_GardenaSmartDevice.pm index db63b3a..801e015 100644 --- a/FHEM/74_GardenaSmartDevice.pm +++ b/FHEM/74_GardenaSmartDevice.pm @@ -502,7 +502,7 @@ sub Set { if ( AttrVal( $name, 'model', 'unknown' ) eq 'sensor' && ReadingsVal($name, 'device_info-category', 'unknown') eq 'sensor' ); - $list .= 'on:noArg off:noArg on-for-timer:slider,0,1,60' + $list .= 'on:noArg off:noArg on-for-timer:slider,0,1,720' if ( AttrVal( $name, 'model', 'unknown' ) eq 'power' ); # all devices has abilitie to fall a sleep $list .= ' winter_mode:awake,hibernate'; diff --git a/controls_GardenaSmartDevice.txt b/controls_GardenaSmartDevice.txt index 4507d86..504f087 100644 --- a/controls_GardenaSmartDevice.txt +++ b/controls_GardenaSmartDevice.txt @@ -1,2 +1,2 @@ UPD 2021-06-28_15:56:58 47009 FHEM/73_GardenaSmartBridge.pm -UPD 2021-07-13_17:21:48 56216 FHEM/74_GardenaSmartDevice.pm +UPD 2021-07-16_20:26:01 56217 FHEM/74_GardenaSmartDevice.pm