FHEM/mod-GardenaSmart
1
0
Fork 0
Code Issues 2 Pull Requests Releases 3 Wiki Activity

[final] - removed debug print lines, cleanup code

Browse Source
This commit is contained in:
Sebastian 2022-08-09 14:52:34 +02:00
parent 71b435d90b
commit 8b9ce793cd
3 changed files with 6 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGED
View File

@ -1 +1 @@
[fix] - debug output [fix] - schedules + debug

16
FHEM/74_GardenaSmartDevice.pm
View File

@ -855,17 +855,15 @@ sub WriteReadings {
} }
} }
use Data::Dumper;
foreach my $dev_schedules ( sort keys %{ $hash->{READINGS} } ) { foreach my $dev_schedules ( sort keys %{ $hash->{READINGS} } ) {
my $dev_reading = ReadingsVal( $name, $dev_schedules, "error" ); my $dev_reading = ReadingsVal( $name, $dev_schedules, "error" );
push @ist, $dev_reading if $dev_schedules =~ /schedule.*\d_id/; # push reading _id push @ist, $dev_reading if $dev_schedules =~ /schedule.*\d_id/; # push reading _id
push @ist, $1 if $dev_schedules =~ /schedule.*_(\d)_id/; # push readigs d from x_id push @ist, $1 if $dev_schedules =~ /schedule.*_(\d)_id/; # push readigs d from x_id
Log3 $name, 5, "[DEBUG] $name - Key ist : $dev_schedules "; Log3 $name, 5, "[DEBUG] $name - Schedule - Key ist : $dev_schedules ";
Log3 $name, 5, "[DDDDD] $name - ID FOUND $dev_reading" if $dev_schedules =~ /schedule.*_\d_id/; # cloud hat SOLL Log3 $name, 5, "[DEBUG] $name - Schedule - ID FOUND $dev_reading" if $dev_schedules =~ /schedule.*_\d_id/; # cloud hat SOLL
} }
Log3 $name, 5, "[OOOU] Cloud ".Dumper(@soll) . "- Ist:". Dumper(@ist); #Log3 $name, 5, "[DEBUG] Cloud:".Dumper(@soll) . "- Internal:". Dumper(@ist);
## delete only if cloud != (ist/2) ## delete only if cloud != (ist/2)
if ((scalar(@soll) != scalar(@ist/2) if ((scalar(@soll) != scalar(@ist/2)
@ -878,20 +876,14 @@ use Data::Dumper;
foreach my $sist (@tmp_ist) { foreach my $sist (@tmp_ist) {
my $step = scalar(@tmp_ist) > 1 ? 2:1; my $step = scalar(@tmp_ist) > 1 ? 2:1;
#print "step laenge $step \n";
print "check $element = $sist\n";
if ($element eq $sist){ if ($element eq $sist){
#splice(@ist, $schedule_step_int, 1); # more than 2 items del them, otherwise 1
splice(@ist, $schedule_step_int, $step); # more than 2 items del them, otherwise 1 splice(@ist, $schedule_step_int, $step); # more than 2 items del them, otherwise 1
#$schedule_step_int++;
} }
#$schedule_step_int++;
$schedule_step_int += $step; $schedule_step_int += $step;
} }
} }
} }
Log3 $name, 5, "[REST] ". Dumper(@ist); Log3 $name, 5, "[DEBUG] $name - Schedule - Rest ". Dumper(@ist);
# delete only if count soll != count ist. cos the will be overwritten # delete only if count soll != count ist. cos the will be overwritten
if (scalar(@ist) > 0 if (scalar(@ist) > 0
&& scalar(@soll) != scalar(@ist/2) ){ && scalar(@soll) != scalar(@ist/2) ){

2
controls_GardenaSmartDevice.txt
View File

@ -1,2 +1,2 @@
UPD 2022-07-21_19:43:48 49634 FHEM/73_GardenaSmartBridge.pm UPD 2022-07-21_19:43:48 49634 FHEM/73_GardenaSmartBridge.pm
UPD 2022-08-09_10:33:55 107783 FHEM/74_GardenaSmartDevice.pm UPD 2022-08-09_14:51:26 107551 FHEM/74_GardenaSmartDevice.pm