From 78e9906e6b2f42694c0c4484a87032572320df1a Mon Sep 17 00:00:00 2001
From: Sebastian <em@ail.tld>
Date: Thu, 28 Apr 2022 20:17:22 +0200
Subject: [PATCH] fix debug

---
 CHANGED                         |  2 +-
 FHEM/74_GardenaSmartDevice.pm   | 32 ++++++++++++++++----------------
 controls_GardenaSmartDevice.txt |  2 +-
 3 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/CHANGED b/CHANGED
index abedab2..e4fe25a 100644
--- a/CHANGED
+++ b/CHANGED
@@ -1 +1 @@
-    fix code
+    fix
diff --git a/FHEM/74_GardenaSmartDevice.pm b/FHEM/74_GardenaSmartDevice.pm
index 87fa29f..aa7d131 100644
--- a/FHEM/74_GardenaSmartDevice.pm
+++ b/FHEM/74_GardenaSmartDevice.pm
@@ -784,22 +784,6 @@ sub WriteReadings {
               readingsBulkUpdateIfChanged( $hash, 'scheduling-'.$decode_json->{settings}[$settings]{name},
                                   $decode_json->{settings}[$settings]{value} );
             }
-            if ($decode_json->{settings}[$settings]{name} eq 'valve_names') {
-              Log3 $name, 3,  "[DEBUG] - GardenaSmartDevice ($name) - ".ref( $decode_json->{settings}[$settings]{value} );
-            }
-
-            if ($decode_json->{settings}[$settings]{name} eq 'valve_names'
-                && ref( $decode_json->{settings}[$settings]{value} ) eq "ARRAY" ) { # or HASH ?
-              #_name_1  =  
-              Log3 $name, 3,  "GardenaSmartDevice ($name) valve_names ";
-              my @valves = @{$decode_json->{settings}[$settings]{value}};
-              foreach my $valve( @valves ) {
-                Log3 $name, 3,  "GardenaSmartDevice ($name) valve_name $valve->{'name'}";
-
-              readingsBulkUpdateIfChanged( $hash, 'valve-valve_name_'.$valve->{"id"},
-                                                  $valve->{"name"} );
-              }
-            }
 
             ######
             # save winter mode as reading
@@ -811,6 +795,22 @@ sub WriteReadings {
             }
         }
 
+        if ($decode_json->{settings}[$settings]{name} eq 'valve_names') {
+            Log3 $name, 3,  "[DEBUG] - GardenaSmartDevice ($name) - ".ref( $decode_json->{settings}[$settings]{value} );
+        }
+
+        if ($decode_json->{settings}[$settings]{name} eq 'valve_names'
+          && ref( $decode_json->{settings}[$settings]{value} ) eq "ARRAY" ) { # or HASH ?
+          #_name_1  =  
+            Log3 $name, 3,  "GardenaSmartDevice ($name) valve_names ";
+            my @valves = @{$decode_json->{settings}[$settings]{value}};
+            foreach my $valve( @valves ) {
+              Log3 $name, 3,  "GardenaSmartDevice ($name) valve_name $valve->{'name'}";
+              readingsBulkUpdateIfChanged( $hash, 'valve-valve_name_'.$valve->{"id"},
+                                           $valve->{"name"} );
+            }
+        }
+
         if ( ref( $decode_json->{settings}[$settings]{value} ) eq "ARRAY"
             && $decode_json->{settings}[$settings]{name} eq 'starting_points' )
         {
diff --git a/controls_GardenaSmartDevice.txt b/controls_GardenaSmartDevice.txt
index db26b43..d666fd7 100644
--- a/controls_GardenaSmartDevice.txt
+++ b/controls_GardenaSmartDevice.txt
@@ -1,2 +1,2 @@
 UPD 2022-03-29_13:42:09 49520 FHEM/73_GardenaSmartBridge.pm
-UPD 2022-04-18_19:16:13 65595 FHEM/74_GardenaSmartDevice.pm
+UPD 2022-04-28_20:17:10 65550 FHEM/74_GardenaSmartDevice.pm