From 63443d75b4c8e41ac94408f7832c4a3095b6e2dd Mon Sep 17 00:00:00 2001 From: Sebastian Date: Mon, 11 Jul 2022 20:22:27 +0200 Subject: [PATCH] [add] - cancleValve for conencted valvs only --- CHANGED | 2 +- FHEM/74_GardenaSmartDevice.pm | 14 ++++++++++++-- controls_GardenaSmartDevice.txt | 2 +- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/CHANGED b/CHANGED index a6803f0..62a74ed 100644 --- a/CHANGED +++ b/CHANGED @@ -1 +1 @@ - [fix] state , initial nearst fallback, paused untel readded - paused_until is UTC no bug -> calc for state in localtim + [enhancement] - change stopSchedule and resumeSchedule setter to connected valves diff --git a/FHEM/74_GardenaSmartDevice.pm b/FHEM/74_GardenaSmartDevice.pm index 514ebf7..fb93c29 100644 --- a/FHEM/74_GardenaSmartDevice.pm +++ b/FHEM/74_GardenaSmartDevice.pm @@ -527,9 +527,19 @@ sub Set { if ( AttrVal( $name, 'model', 'unknown' ) eq 'watering_computer' ); $list .= -'closeAllValves:noArg stopScheduleValve:select,'.ReadingsVal( $name, 'ic24-valves_connected', '1' ).' resumeScheduleValve:select,'.ReadingsVal( $name, 'ic24-valves_connected', '1' ).' manualDurationValve1:slider,1,1,90 manualDurationValve2:slider,1,1,90 manualDurationValve3:slider,1,1,90 manualDurationValve4:slider,1,1,90 manualDurationValve5:slider,1,1,90 manualDurationValve6:slider,1,1,90 cancelOverrideValve1:noArg cancelOverrideValve2:noArg cancelOverrideValve3:noArg cancelOverrideValve4:noArg cancelOverrideValve5:noArg cancelOverrideValve6:noArg' +'closeAllValves:noArg stopScheduleValve:select,'.ReadingsVal( $name, 'ic24-valves_connected', '1' ).' resumeScheduleValve:select,'.ReadingsVal( $name, 'ic24-valves_connected', '1' ) if ( AttrVal( $name, 'model', 'unknown' ) eq 'ic24' ); - + + foreach my $valve (split(',', ReadingsVal( $name, 'ic24-valves_connected', '1'))) { + $list .= ' manualDurationValve'.$valve.':slider,1,1,90 ' + if ( AttrVal( $name, 'model', 'unknown' ) eq 'ic24' ); + } + + foreach my $valve (split(',', ReadingsVal( $name, 'ic24-valves_connected', '1'))) { + $list .= ' cancelOverrideValve'.$valve.':noArg ' + if ( AttrVal( $name, 'model', 'unknown' ) eq 'ic24' ); + } + $list .= 'refresh:temperature,humidity' if ( AttrVal( $name, 'model', 'unknown' ) =~ /sensor.?/ ); diff --git a/controls_GardenaSmartDevice.txt b/controls_GardenaSmartDevice.txt index a6ba303..94f5a05 100644 --- a/controls_GardenaSmartDevice.txt +++ b/controls_GardenaSmartDevice.txt @@ -1,2 +1,2 @@ UPD 2022-07-01_16:13:02 49241 FHEM/73_GardenaSmartBridge.pm -UPD 2022-07-11_13:47:43 76336 FHEM/74_GardenaSmartDevice.pm +UPD 2022-07-11_20:22:02 76451 FHEM/74_GardenaSmartDevice.pm