diff --git a/fhem/CHANGED b/fhem/CHANGED index a44aa800e..988080a17 100644 --- a/fhem/CHANGED +++ b/fhem/CHANGED @@ -1,5 +1,6 @@ # Add changes at the top of the list. Keep it in ASCII, and 80-char wide. # Do not insert empty lines here, update check depends on it. + - change: 12_HProtocolGateway: move sensorSystem attribute to HProtocolTank - feature: 98_Verkehrsinfo.pm: add attribut timeout - feature: 12_HProtocolGateway: added 843 protocol for PMS-IB P20 - feature: 12_HProtocolTank: added Product to calculate 15 degrees volume diff --git a/fhem/FHEM/12_HProtocolGateway.pm b/fhem/FHEM/12_HProtocolGateway.pm index e00674f93..53d0eb91e 100644 --- a/fhem/FHEM/12_HProtocolGateway.pm +++ b/fhem/FHEM/12_HProtocolGateway.pm @@ -50,8 +50,7 @@ sub HProtocolGateway_Initialize($) { "databitsLength:5,6,7,8 " . "stopBit:0,1 " . "pollIntervalMins " . - "path " . - "sensorSystem:Hectronic,Unitronics,PMS-IB"; + "path"; } sub HProtocolGateway_Define($$) { @@ -116,7 +115,7 @@ sub HProtocolGateway_GetUpdate($) { $command = "\$C"; } - my $sensorSystem = AttrVal($name, 'sensorSystem', ""); + my $sensorSystem = AttrVal($tankHash->{NAME}, 'sensorSystem', ""); if ( $sensorSystem eq "PMS-IB") { $command = "H"; } @@ -188,7 +187,7 @@ sub HProtocolGateway_ParseMessage($$) { my ($hash, $data, $tankHash) = @_; my $name = $hash->{NAME}; - my $sensorSystem = AttrVal($name, 'sensorSystem', ""); + my $sensorSystem = AttrVal($tankHash->{NAME}, 'sensorSystem', ""); my ($tanknumber,$error,$temperature,$tankdata,$water,$checksum,$version,$probe_offset); @@ -432,7 +431,6 @@ sub HProtocolGateway_Tank($$$) { Define
define <name> HProtocolGateway /dev/tty???
- attr <name> sensorSystem Hectronic
attr <name> pollIntervalMins 2
attr <name> path /opt/fhem/
attr <name> baudrate 1200
@@ -465,8 +463,6 @@ sub HProtocolGateway_Tank($$$) {
Attributes
- - sensorSystem
- Sensor System / Hectronic, Unitronics, PMS-IB
- pollIntervalMins
poll Interval in Mins
- path
diff --git a/fhem/FHEM/12_HProtocolTank.pm b/fhem/FHEM/12_HProtocolTank.pm
index 69104700f..1c1f0f49b 100644
--- a/fhem/FHEM/12_HProtocolTank.pm
+++ b/fhem/FHEM/12_HProtocolTank.pm
@@ -37,6 +37,7 @@ sub HProtocolTank_Initialize($) {
"mode:FillLevel,Volume,Ullage " .
"type " .
"product:Diesel,FuelOil,Petrol " .
+ "sensorSystem:Hectronic,Unitronics,PMS-IB " .
$readingFnAttributes;
}
@@ -129,6 +130,7 @@ sub HProtocolTank_Attr (@) {
define <name> HProtocolTank HProtocolGateway
attr <name> hID 01
+ attr <name> sensorSystem Hectronic
attr <name> product FuelOil
@@ -165,6 +167,8 @@ sub HProtocolTank_Attr (@) {
- hID
01 - 32 Tank Number / Tank Address (99 for testing only)
+ - sensorSystem
+ Sensor System / Hectronic, Unitronics, PMS-IB
- mode
Mode / FillLevel, Volume, Ullage
- type