FHEM/fhem-mirror
2
0
Fork 0
mirror of https://github.com/fhem/fhem-mirror.git synced 2025-03-03 16:56:54 +00:00
Code Issues Releases Wiki Activity

14_SD_BELL.pm: revised code

Browse Source 
git-svn-id: https://svn.fhem.de/fhem/trunk@23222 2b470e98-0d58-463d-a4d8-8e2adae1ed80
This commit is contained in:
HomeAuto_User 2020-11-23 21:27:08 +00:00
parent b393645f95
commit e922daabb2
2 changed files with 407 additions and 393 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
fhem/CHANGED
View File

@ -1,5 +1,6 @@
# Add changes at the top of the list. Keep it in ASCII, and 80-char wide. # Add changes at the top of the list. Keep it in ASCII, and 80-char wide.
# Do not insert empty lines here, update check depends on it. # Do not insert empty lines here, update check depends on it.
- change: 14_SD_BELL: revised code Perl::Critic
- feature: 14_SD_UT.pm - feature: 14_SD_UT.pm
model Novy_840039: added cmd reset_clean_led model Novy_840039: added cmd reset_clean_led
revised code Perl::Critic revised code Perl::Critic

251
fhem/FHEM/14_SD_BELL.pm
View File

@ -3,7 +3,8 @@
# #
# The file is part of the SIGNALduino project. # The file is part of the SIGNALduino project.
# The purpose of this module is to support many wireless BELL devices. # The purpose of this module is to support many wireless BELL devices.
# 2018 - 2020 - HomeAuto_User & elektron-bbs #
# 2018-2020 - HomeAuto_User, elektron-bbs
# #
#################################################################################################################################### ####################################################################################################################################
# - wireless doorbell TCM_234759 Tchibo [Protocol 15] length 12-20 (3-5) # - wireless doorbell TCM_234759 Tchibo [Protocol 15] length 12-20 (3-5)
@ -43,59 +44,59 @@ use lib::SD_Protocols;
### HASH for all modul models ### ### HASH for all modul models ###
my %models = ( my %models = (
# keys(model) => values # keys(model) => values
"unknown" => { hex_lengh => "99", # length only for comparison 'unknown' => { hex_lengh => '99', # length only for comparison
Protocol => "00", Protocol => '00',
doubleCode => "no" doubleCode => 'no'
}, },
"TCM_234759" => { hex_lengh => "3,4,5", 'TCM_234759' => { hex_lengh => '3,4,5',
Protocol => "15", Protocol => '15',
doubleCode => "no" doubleCode => 'no'
}, },
"FreeTec_PE-6946" => { hex_lengh => "6", 'FreeTec_PE-6946' => { hex_lengh => '6',
Protocol => "32", Protocol => '32',
doubleCode => "no" doubleCode => 'no'
}, },
"Elro_DB200_/_KANGTAI_/_unitec" => { hex_lengh => "8", 'Elro_DB200_/_KANGTAI_/_unitec' => { hex_lengh => '8',
Protocol => "41", Protocol => '41',
doubleCode => "yes" doubleCode => 'yes'
}, },
"Pollin_551227" => { hex_lengh => "7", 'Pollin_551227' => { hex_lengh => '7',
Protocol => "42", Protocol => '42',
doubleCode => "no" doubleCode => 'no'
}, },
"FG_/_Basic-Serie" => { hex_lengh => "6", 'FG_/_Basic-Serie' => { hex_lengh => '6',
Protocol => "57", Protocol => '57',
doubleCode => "no" doubleCode => 'no'
}, },
"Heidemann_|_Heidemann_HX_|_VTX-BELL" => { hex_lengh => "3", 'Heidemann_|_Heidemann_HX_|_VTX-BELL' => { hex_lengh => '3',
Protocol => "79", Protocol => '79',
doubleCode => "no" doubleCode => 'no'
}, },
"Grothe_Mistral_SE_01" => { hex_lengh => "6", # length of device def, not message!!! message length = "10" 'Grothe_Mistral_SE_01' => { hex_lengh => '6', # length of device def, not message!!! message length = '10'
Protocol => "96", Protocol => '96',
doubleCode => "no" doubleCode => 'no'
}, },
"Grothe_Mistral_SE_03" => { hex_lengh => "6", # length of device def, not message!!! message length = "12" 'Grothe_Mistral_SE_03' => { hex_lengh => '6', # length of device def, not message!!! message length = '12'
Protocol => "96", Protocol => '96',
doubleCode => "no" doubleCode => 'no'
}, },
"GEA-028DB" => { hex_lengh => "4", 'GEA-028DB' => { hex_lengh => '4',
Protocol => "98", Protocol => '98',
doubleCode => "no" doubleCode => 'no'
}, },
); );
sub SD_BELL_Initialize($) { sub SD_BELL_Initialize($) {
my ($hash) = @_; my ($hash) = @_;
$hash->{Match} = "^P(?:15|32|41|42|57|79|96|98)#.*"; $hash->{Match} = '^P(?:15|32|41|42|57|79|96|98)#.*';
$hash->{DefFn} = "SD_BELL::Define"; $hash->{DefFn} = 'SD_BELL::Define';
$hash->{UndefFn} = "SD_BELL::Undef"; $hash->{UndefFn} = 'SD_BELL::Undef';
$hash->{ParseFn} = "SD_BELL::Parse"; $hash->{ParseFn} = 'SD_BELL::Parse';
$hash->{SetFn} = "SD_BELL::Set"; $hash->{SetFn} = 'SD_BELL::Set';
$hash->{AttrFn} = "SD_BELL::Attr"; $hash->{AttrFn} = 'SD_BELL::Attr';
$hash->{AttrList} = "repeats:1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,20,25,30 IODev do_not_notify:1,0 ignore:0,1 showtime:1,0 model:".join(",", sort keys %models) . " $main::readingFnAttributes"; $hash->{AttrList} = 'repeats:1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,20,25,30 IODev do_not_notify:1,0 ignore:0,1 showtime:1,0 model:'.join(',', sort keys %models) . " $main::readingFnAttributes";
$hash->{AutoCreate} = {"SD_BELL.*" => {FILTER => "%NAME", autocreateThreshold => "4:180", GPLOT => ""}}; $hash->{AutoCreate} = {'SD_BELL.*' => {FILTER => '%NAME', autocreateThreshold => '4:180', GPLOT => ''}};
} }
### unterer Teil ### ### unterer Teil ###
@ -107,7 +108,7 @@ use POSIX;
use GPUtils qw(:all); # wird für den Import der FHEM Funktionen aus der fhem.pl benötigt use GPUtils qw(:all); # wird für den Import der FHEM Funktionen aus der fhem.pl benötigt
my $missingModul = ""; my $missingModul = '';
## Import der FHEM Funktionen ## Import der FHEM Funktionen
BEGIN { BEGIN {
@ -137,32 +138,34 @@ sub Define($$) {
my $name = $hash->{NAME}; my $name = $hash->{NAME};
my $protocol = $a[2]; my $protocol = $a[2];
my $hex_lengh = length($a[3]); my $hex_lengh = length($a[3]);
my $doubleCode = "no"; my $doubleCode = 'no';
my $iodevice;
my $ioname;
#Log3 $name, 3, "SD_BELL_Def name=$a[0] protocol=$protocol HEX-Value=$a[3] hex_lengh=$hex_lengh"; #Log3 $name, 3, "SD_BELL_Def name=$a[0] protocol=$protocol HEX-Value=$a[3] hex_lengh=$hex_lengh";
# Argument 0 1 2 3 4 # Argument 0 1 2 3 4
return "SD_BELL: wrong syntax: define <name> SD_BELL <Protocol> <HEX-Value> <optional IODEV>" if(int(@a) < 3 || int(@a) > 5); return 'SD_BELL: wrong syntax: define <name> SD_BELL <Protocol> <HEX-Value> <optional IODEV>' if(int(@a) < 3 || int(@a) > 5);
### checks - doubleCode yes ### ### checks - doubleCode yes ###
return "SD_BELL: wrong <protocol> $a[2]" if not($a[2] =~ /^(?:15|32|41|42|57|79|96|98)/s); return "SD_BELL: wrong <protocol> $a[2]" if not($a[2] =~ /^(?:15|32|41|42|57|79|96|98)/xms);
return "SD_BELL: wrong HEX-Value! Protocol $a[2] HEX-Value <$a[3]> not HEX (0-9 | a-f | A-F)" if (($protocol != 41) && not $a[3] =~ /^[0-9a-fA-F]*$/s); return "SD_BELL: wrong HEX-Value! Protocol $a[2] HEX-Value <$a[3]> not HEX (0-9 | a-f | A-F)" if (($protocol != 41) && not $a[3] =~ /^[0-9a-fA-F]*$/xms);
return "SD_BELL: wrong HEX-Value! Protocol $a[2] HEX-Value <$a[3]> not HEX (0-9 | a-f | A-F) or length wrong!" if (($protocol == 41) && not $a[3] =~ /^[0-9a-fA-F]{8}_[0-9a-fA-F]{8}$/s); return "SD_BELL: wrong HEX-Value! Protocol $a[2] HEX-Value <$a[3]> not HEX (0-9 | a-f | A-F) or length wrong!" if (($protocol == 41) && not $a[3] =~ /^[0-9a-fA-F]{8}_[0-9a-fA-F]{8}$/xms);
($hash_name) = grep { $models{$_}{Protocol} eq $protocol } keys %models; # search protocol --> model ($hash_name) = grep { $models{$_}{Protocol} eq $protocol } keys %models; # search protocol --> model
$doubleCode = $models{$hash_name}{doubleCode}; # read note doubleCode $doubleCode = $models{$hash_name}{doubleCode}; # read note doubleCode
$hash->{doubleCode} = "Code alternates between two RAWMSG" if($protocol == 41); $hash->{doubleCode} = 'Code alternates between two RAWMSG' if($protocol == 41);
$hash->{lastMSG} = ""; $hash->{lastMSG} = '';
$hash->{bitMSG} = ""; $hash->{bitMSG} = '';
my $iodevice = $a[4] if($a[4]); $iodevice = $a[4] if($a[4]);
$modules{SD_BELL}{defptr}{$hash->{DEF}} = $hash; $modules{SD_BELL}{defptr}{$hash->{DEF}} = $hash;
my $ioname = $modules{SD_BELL}{defptr}{ioname} if (exists $modules{SD_BELL}{defptr}{ioname} && not $iodevice); $ioname = $modules{SD_BELL}{defptr}{ioname} if (exists $modules{SD_BELL}{defptr}{ioname} && not $iodevice);
$iodevice = $ioname if not $iodevice; $iodevice = $ioname if not $iodevice;
### Attributes | model set after codesyntax ### ### Attributes | model set after codesyntax ###
$attr{$name}{model} = $hash_name if ( not exists($attr{$name}{model}) ); # set model, if only undef --> new def $attr{$name}{model} = $hash_name if ( not exists($attr{$name}{model}) ); # set model, if only undef --> new def
$attr{$name}{room} = "SD_BELL" if ( not exists( $attr{$name}{room} ) ); # set room, if only undef --> new def $attr{$name}{room} = 'SD_BELL' if ( not exists( $attr{$name}{room} ) ); # set room, if only undef --> new def
AssignIoPort($hash, $iodevice); AssignIoPort($hash, $iodevice);
} }
@ -172,38 +175,38 @@ sub Set($$$@) {
my ( $hash, $name, @a ) = @_; my ( $hash, $name, @a ) = @_;
my $cmd = $a[0]; my $cmd = $a[0];
my $ioname = $hash->{IODev}{NAME}; my $ioname = $hash->{IODev}{NAME};
my $model = AttrVal($name, "model", "unknown"); my $model = AttrVal($name, 'model', 'unknown');
my @split = split(" ", $hash->{DEF}); my @split = split(' ', $hash->{DEF});
my @splitCode = ""; # for doubleCode my @splitCode = ''; # for doubleCode
my $protocol = $split[0]; my $protocol = $split[0];
my $repeats = AttrVal($name,'repeats', '5'); my $repeats = AttrVal($name,'repeats', '5');
my $doubleCodeCheck; my $doubleCodeCheck;
my $ret = undef; my $ret = undef;
if ($cmd eq "?") { if ($cmd eq '?') {
$ret .= "ring:noArg"; $ret .= 'ring:noArg';
$ret .= " Alarm:noArg" if ($protocol == 96); # only Grothe_Mistral_SE $ret .= ' Alarm:noArg' if ($protocol == 96); # only Grothe_Mistral_SE
} else { } else {
if ($protocol == 96) {; # only Grothe_Mistral_SE if ($protocol == 96) {; # only Grothe_Mistral_SE
# set sduino434 raw SC;;R=5;;SR;;R=1;;P0=1500;;P1=-215;;D=01;;SM;;R=1;;C=215;;D=47104762003F;; # set sduino434 raw SC;;R=5;;SR;;R=1;;P0=1500;;P1=-215;;D=01;;SM;;R=1;;C=215;;D=47104762003F;;
my $msg = "SC;;R="; my $msg = 'SC;;R=';
$msg .= $repeats; $msg .= $repeats;
$msg .= ";SR;R=1;P0=1500;P1=-215;D=01;SM;R=1;C=215;D=47"; $msg .= ';SR;R=1;P0=1500;P1=-215;D=01;SM;R=1;C=215;D=47';
my $id = $split[1]; my $id = $split[1];
$id = sprintf('%06X', hex(substr($id,0,6)) | 0x800000) if ($cmd eq "Alarm"); # set alarm bit $id = sprintf('%06X', hex(substr($id,0,6)) | 0x800000) if ($cmd eq 'Alarm'); # set alarm bit
$msg .= $id; $msg .= $id;
my $checksum = sprintf('%02X', ((0x47 + hex(substr($id,0,2)) + hex(substr($id,2,2)) + hex(substr($id,4,2))) & 0xFF)); my $checksum = sprintf('%02X', ((0x47 + hex(substr($id,0,2)) + hex(substr($id,2,2)) + hex(substr($id,4,2))) & 0xFF));
$msg .= $checksum; $msg .= $checksum;
my $model = AttrVal($name,'model', 'Grothe_Mistral_SE_01'); my $model = AttrVal($name,'model', 'Grothe_Mistral_SE_01');
$msg .= "3F" if ($model eq "Grothe_Mistral_SE_03"); # only Grothe_Mistral_SE_03 $msg .= '3F' if ($model eq 'Grothe_Mistral_SE_03'); # only Grothe_Mistral_SE_03
$msg .= ";"; $msg .= ';';
IOWrite($hash, 'raw', $msg); IOWrite($hash, 'raw', $msg);
Log3 $name, 4, "$ioname: $name $msg"; Log3 $name, 4, "$ioname: $name $msg";
} else { } else {
my $rawDatasend = $split[1]; # hex value from def without protocol my $rawDatasend = $split[1]; # hex value from def without protocol
if ($rawDatasend =~ /[0-9a-fA-F]_[0-9a-fA-F]/s) { # check doubleCode in def if ($rawDatasend =~ /[0-9a-fA-F]_[0-9a-fA-F]/xms) { # check doubleCode in def
$doubleCodeCheck = 1; $doubleCodeCheck = 1;
@splitCode = split("_", $rawDatasend); @splitCode = split('_', $rawDatasend);
$rawDatasend = $splitCode[0]; $rawDatasend = $splitCode[0];
} else { } else {
$doubleCodeCheck = 0; $doubleCodeCheck = 0;
@ -216,8 +219,8 @@ sub Set($$$@) {
my $bitData = unpack("B$blen", pack("H$hlen", $rawDatasend)); my $bitData = unpack("B$blen", pack("H$hlen", $rawDatasend));
my $msg = "P$protocol#" . $bitData; my $msg = "P$protocol#" . $bitData;
if ($model eq "Heidemann_|_Heidemann_HX_|_VTX-BELL") { if ($model eq 'Heidemann_|_Heidemann_HX_|_VTX-BELL') {
$msg .= "#R135"; $msg .= '#R135';
} else { } else {
$msg .= "#R$repeats"; $msg .= "#R$repeats";
} }
@ -226,18 +229,28 @@ sub Set($$$@) {
IOWrite($hash, 'sendMsg', $msg); IOWrite($hash, 'sendMsg', $msg);
} }
} }
Log3 $name, 3, "$ioname: $name set $cmd" if ($cmd ne "?"); Log3 $name, 3, "$ioname: $name set $cmd" if ($cmd ne '?');
readingsSingleUpdate($hash, "state" , $cmd, 1) if ($cmd ne "?"); readingsSingleUpdate($hash, 'state' , $cmd, 1) if ($cmd ne '?');
return $ret; return $ret;
} }
################################### ###################################
sub Undef($$) { sub Undef($$) {
my ($hash, $name) = @_; my ($hash, $name) = @_;
delete($modules{SD_BELL}{defptr}{$hash->{DEF}}) if(defined($hash->{DEF}) && defined($modules{SD_BELL}{defptr}{$hash->{DEF}}));
delete($modules{SD_BELL}{defptr}{doubleCode}) if(defined($modules{SD_BELL}{defptr}{defptr}{doubleCode})); if(defined($hash->{DEF}) && defined($modules{SD_BELL}{defptr}{$hash->{DEF}})) {
delete($modules{SD_BELL}{defptr}{doubleCode_Time}) if(defined($modules{SD_BELL}{defptr}{defptr}{doubleCode_Time})); delete($modules{SD_BELL}{defptr}{$hash->{DEF}});
return undef; }
if(defined($modules{SD_BELL}{defptr}{defptr}{doubleCode})) {
delete($modules{SD_BELL}{defptr}{doubleCode});
}
if(defined($modules{SD_BELL}{defptr}{defptr}{doubleCode_Time})) {
delete($modules{SD_BELL}{defptr}{doubleCode_Time});
}
return;
} }
@ -245,16 +258,16 @@ sub Undef($$) {
sub Parse($$) { sub Parse($$) {
my ($iohash, $msg) = @_; my ($iohash, $msg) = @_;
my $ioname = $iohash->{NAME}; my $ioname = $iohash->{NAME};
my ($protocol,$rawData) = split("#",$msg); my ($protocol,$rawData) = split('#',$msg);
$protocol=~ s/^[u|U|P](\d+)/$1/; # extract protocol ID, $1 = ID $protocol=~ s/^[u|U|P](\d+)/$1/; # extract protocol ID, $1 = ID
my $hlen = length($rawData); my $hlen = length($rawData);
my $blen = $hlen * 4; my $blen = $hlen * 4;
my $bitData = unpack("B$blen", pack("H$hlen", $rawData)); my $bitData = unpack("B$blen", pack("H$hlen", $rawData));
my $doubleCode_known = "0"; # marker, RAWMSG known in defpr my $doubleCode_known = '0'; # marker, RAWMSG known in defpr
my ($hash_name) = grep { $models{$_}{Protocol} eq $protocol } keys %models; # search protocol --> model my ($hash_name) = grep { $models{$_}{Protocol} eq $protocol } keys %models; # search protocol --> model
my $deviceCode = $rawData; my $deviceCode = $rawData;
my $devicedef; my $devicedef;
my $state = "ring"; my $state = 'ring';
my $bat; my $bat;
Log3 $iohash, 4, "$ioname: SD_BELL_Parse protocol $protocol $hash_name doubleCode=".$models{$hash_name}{doubleCode}." rawData=$rawData"; Log3 $iohash, 4, "$ioname: SD_BELL_Parse protocol $protocol $hash_name doubleCode=".$models{$hash_name}{doubleCode}." rawData=$rawData";
@ -262,40 +275,40 @@ sub Parse($$) {
## loop to view SD_BELL defined defptr ## ## loop to view SD_BELL defined defptr ##
if ($protocol == 41) { if ($protocol == 41) {
foreach my $d(sort keys %{$modules{SD_BELL}{defptr}}) { foreach my $d(sort keys %{$modules{SD_BELL}{defptr}}) {
Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol defptr - $d is defined!" if ($d =~ /$protocol/s); Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol defptr - $d is defined!" if ($d =~ /$protocol/xms);
if ($d =~ /$rawData/s) { if ($d =~ /$rawData/xms) {
my @doubleCode = split(" ",$d); # split two RAWMSG from protocol in def 41 BA7983D3_3286D393 my @doubleCode = split(' ',$d); # split two RAWMSG from protocol in def 41 BA7983D3_3286D393
$doubleCode_known = $doubleCode[1]; # RAWMSG are in split RAWMSG $doubleCode_known = $doubleCode[1]; # RAWMSG are in split RAWMSG
Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol defptr - $rawData is already registered!" Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol defptr - $rawData is already registered!"
} }
} }
$modules{SD_BELL}{defptr}{doubleCode_Time} = 0 if (!exists $modules{SD_BELL}{defptr}{doubleCode_Time}); $modules{SD_BELL}{defptr}{doubleCode_Time} = 0 if (!exists $modules{SD_BELL}{defptr}{doubleCode_Time});
Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - doubleCode_Time_old=".$modules{SD_BELL}{defptr}{doubleCode_Time}." Time_now=".time()." Diff=".(time()-$modules{SD_BELL}{defptr}{doubleCode_Time}); Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - doubleCode_Time_old=".$modules{SD_BELL}{defptr}{doubleCode_Time}.' Time_now='.time().' Diff='.(time()-$modules{SD_BELL}{defptr}{doubleCode_Time});
if ((time() - $modules{SD_BELL}{defptr}{doubleCode_Time} > 15) && $doubleCode_known eq "0") { # max timediff 15 seconds if ((time() - $modules{SD_BELL}{defptr}{doubleCode_Time} > 15) && $doubleCode_known eq '0') { # max timediff 15 seconds
Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - pointer <doubleCode> not exists!" if (not exists $modules{SD_BELL}{defptr}{doubleCode}); Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - pointer <doubleCode> not exists!" if (not exists $modules{SD_BELL}{defptr}{doubleCode});
Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - pointer <doubleCode> ".$modules{SD_BELL}{defptr}{doubleCode}." deleted! RAWMSG too old!" if (exists $modules{SD_BELL}{defptr}{doubleCode}); Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - pointer <doubleCode> ".$modules{SD_BELL}{defptr}{doubleCode}.' deleted! RAWMSG too old!' if (exists $modules{SD_BELL}{defptr}{doubleCode});
delete ($modules{SD_BELL}{defptr}{doubleCode}) if (exists $modules{SD_BELL}{defptr}{doubleCode}); delete ($modules{SD_BELL}{defptr}{doubleCode}) if (exists $modules{SD_BELL}{defptr}{doubleCode});
$modules{SD_BELL}{defptr}{doubleCode_Time} = time(); # set time for new RAWMSG $modules{SD_BELL}{defptr}{doubleCode_Time} = time(); # set time for new RAWMSG
return ""; return '';
} }
### doubleCode yes and RAWMSG are unknown in def ### ### doubleCode yes and RAWMSG are unknown in def ###
if ($models{$hash_name}{doubleCode} eq "yes" && $doubleCode_known eq "0") { # !defs if ($models{$hash_name}{doubleCode} eq 'yes' && $doubleCode_known eq '0') { # !defs
Log3 $iohash, 3, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - doubleCode known $doubleCode_known in defptr. autocreate are not complete finish!"; Log3 $iohash, 3, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - doubleCode known $doubleCode_known in defptr. autocreate are not complete finish!";
if (exists $modules{SD_BELL}{defptr}{doubleCode}) { if (exists $modules{SD_BELL}{defptr}{doubleCode}) {
Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - pointer <doubleCode> data already exists!"; Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - pointer <doubleCode> data already exists!";
} else { } else {
$modules{SD_BELL}{defptr}{doubleCode} = $rawData."_doubleCode"; # first RAWMSG | reset marker, RAWMSG other $modules{SD_BELL}{defptr}{doubleCode} = $rawData.'_doubleCode'; # first RAWMSG | reset marker, RAWMSG other
$modules{SD_BELL}{defptr}{doubleCode_Time} = time(); # set time from new RAWMSG $modules{SD_BELL}{defptr}{doubleCode_Time} = time(); # set time from new RAWMSG
Log3 $iohash, 3, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - ".$modules{SD_BELL}{defptr}{doubleCode}." new defined!"; Log3 $iohash, 3, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - ".$modules{SD_BELL}{defptr}{doubleCode}.' new defined!';
return ""; return '';
} }
if ($modules{SD_BELL}{defptr}{doubleCode} =~ /_doubleCode/s ) { # check of 2 RAWMSG if ($modules{SD_BELL}{defptr}{doubleCode} =~ /_doubleCode/s ) { # check of 2 RAWMSG
my @doubleCode = split("_",$modules{SD_BELL}{defptr}{doubleCode}); my @doubleCode = split('_',$modules{SD_BELL}{defptr}{doubleCode});
# Codes - common ground unknown !! # # Codes - common ground unknown !! #
#################################### ####################################
@ -318,32 +331,32 @@ sub Parse($$) {
# if ($check_4 != 1 || $check_5 != 1 || $check_6 != 1 || $check_7 != 1) { # if ($check_4 != 1 || $check_5 != 1 || $check_6 != 1 || $check_7 != 1) {
# Log3 $iohash, 3, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - RAWMSG check failed ($check_4 $check_5 $check_6 $check_7)"; # Log3 $iohash, 3, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - RAWMSG check failed ($check_4 $check_5 $check_6 $check_7)";
# return ""; # return '';
# } # }
### messages are verified ### ### messages are verified ###
if ($modules{SD_BELL}{defptr}{doubleCode} =~ /$rawData/s) { # check, part known if ($modules{SD_BELL}{defptr}{doubleCode} =~ /$rawData/xms) { # check, part known
Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - $rawData is already known!"; Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - $rawData is already known!";
} else { # new part } else { # new part
$modules{SD_BELL}{defptr}{doubleCode} = $doubleCode[0]."_".$rawData; $modules{SD_BELL}{defptr}{doubleCode} = $doubleCode[0].'_'.$rawData;
Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - $rawData part two for defptr find!"; Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - $rawData part two for defptr find!";
} }
Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - ".$modules{SD_BELL}{defptr}{doubleCode}." complete for defptr"; Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - ".$modules{SD_BELL}{defptr}{doubleCode}.' complete for defptr';
$deviceCode = $modules{SD_BELL}{defptr}{doubleCode}; $deviceCode = $modules{SD_BELL}{defptr}{doubleCode};
$devicedef = $protocol . " " .$deviceCode; $devicedef = $protocol . ' ' .$deviceCode;
} else { } else {
if ($modules{SD_BELL}{defptr}{doubleCode} =~ /$rawData/s) { # check RAWMSG known if ($modules{SD_BELL}{defptr}{doubleCode} =~ /$rawData/xms) { # check RAWMSG known
Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - $rawData already registered! The system search the second code."; Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - $rawData already registered! The system search the second code.";
$deviceCode = $modules{SD_BELL}{defptr}{doubleCode}; $deviceCode = $modules{SD_BELL}{defptr}{doubleCode};
$devicedef = $protocol . " " .$deviceCode; $devicedef = $protocol . ' ' .$deviceCode;
} else { } else {
Log3 $iohash, 3, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - RAWMSG $rawData failed! Other MSG are registered!"; # Error detections, another bit Log3 $iohash, 3, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - RAWMSG $rawData failed! Other MSG are registered!"; # Error detections, another bit
return ""; return '';
} }
} }
### doubleCode yes and RAWMSG are known in def ### ### doubleCode yes and RAWMSG are known in def ###
} elsif ($models{$hash_name}{doubleCode} eq "yes" && $doubleCode_known ne "0") { } elsif ($models{$hash_name}{doubleCode} eq 'yes' && $doubleCode_known ne '0') {
$devicedef = $protocol . " " .$doubleCode_known; # variant two, RAWMSG in a different order $devicedef = $protocol . ' ' .$doubleCode_known; # variant two, RAWMSG in a different order
Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - $devicedef ready to define!"; # Error detections, another bit Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol doubleCode - $devicedef ready to define!"; # Error detections, another bit
} }
@ -354,7 +367,7 @@ sub Parse($$) {
$deviceCode = substr($deviceCode,0,7); $deviceCode = substr($deviceCode,0,7);
} }
## if RAWMSG send from nano, not cut ## if RAWMSG send from nano, not cut
$devicedef = $protocol . " " .$deviceCode; $devicedef = $protocol . ' ' .$deviceCode;
Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol - $rawData alone"; Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol - $rawData alone";
### Grothe_Mistral_SE 01 or 03 length 10 or 12 nibble ### ### Grothe_Mistral_SE 01 or 03 length 10 or 12 nibble ###
@ -362,17 +375,17 @@ sub Parse($$) {
my $checksum = ((hex(substr($rawData,0,2)) + hex(substr($rawData,2,2)) + hex(substr($rawData,4,2)) + hex(substr($rawData,6,2))) & 0xFF); my $checksum = ((hex(substr($rawData,0,2)) + hex(substr($rawData,2,2)) + hex(substr($rawData,4,2)) + hex(substr($rawData,6,2))) & 0xFF);
if ($checksum != hex(substr($rawData,8,2))) { if ($checksum != hex(substr($rawData,8,2))) {
Log3 $iohash, 3, "$ioname: SD_BELL_Parse Grothe_Mistral_SE $deviceCode - ERROR checksum $checksum"; Log3 $iohash, 3, "$ioname: SD_BELL_Parse Grothe_Mistral_SE $deviceCode - ERROR checksum $checksum";
return ""; return '';
} }
$deviceCode = sprintf('%06X', hex(substr($rawData,2,6)) & 0x7FFFFF); # mask alarm bit $deviceCode = sprintf('%06X', hex(substr($rawData,2,6)) & 0x7FFFFF); # mask alarm bit
$devicedef = $protocol . " " .$deviceCode; $devicedef = $protocol . ' ' .$deviceCode;
$state = "Alarm" if (substr($bitData,8,1) eq "1"); $state = 'Alarm' if (substr($bitData,8,1) eq '1');
$bat = substr($bitData,41,1) eq "0" ? "ok" : "low" if ($hlen == 12); # only Grothe_Mistral_SE_03 $bat = substr($bitData,41,1) eq '0' ? 'ok' : 'low' if ($hlen == 12); # only Grothe_Mistral_SE_03
Log3 $iohash, 4, "$ioname: SD_BELL_Parse Grothe_Mistral_SE P$protocol - $rawData"; Log3 $iohash, 4, "$ioname: SD_BELL_Parse Grothe_Mistral_SE P$protocol - $rawData";
### doubleCode no without P41 ### ### doubleCode no without P41 ###
} else { } else {
$devicedef = $protocol . " " .$deviceCode; $devicedef = $protocol . ' ' .$deviceCode;
Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol - $rawData alone"; Log3 $iohash, 4, "$ioname: SD_BELL_Parse Check P$protocol - $rawData alone";
} }
@ -380,7 +393,7 @@ sub Parse($$) {
$modules{SD_BELL}{defptr}{ioname} = $ioname; $modules{SD_BELL}{defptr}{ioname} = $ioname;
if(!$def) { if(!$def) {
Log3 $iohash, 1, "$ioname: SD_BELL_Parse UNDEFINED BELL detected, Protocol ".$protocol." code " . $deviceCode; Log3 $iohash, 1, "$ioname: SD_BELL_Parse UNDEFINED BELL detected, Protocol ".$protocol.' code ' . $deviceCode;
return "UNDEFINED SD_BELL_$deviceCode SD_BELL $protocol $deviceCode"; return "UNDEFINED SD_BELL_$deviceCode SD_BELL $protocol $deviceCode";
} }
@ -390,17 +403,17 @@ sub Parse($$) {
$hash->{bitMSG} = $bitData; $hash->{bitMSG} = $bitData;
### Grothe_Mistral_SE 01 or 03 length 10 or 12 nibble (only by first message) ### ### Grothe_Mistral_SE 01 or 03 length 10 or 12 nibble (only by first message) ###
if ($protocol == 96 && $hash->{STATE} eq "???") { if ($protocol == 96 && $hash->{STATE} eq '???') {
$attr{$name}{model} = "Grothe_Mistral_SE_01" if ($hlen == 10); $attr{$name}{model} = 'Grothe_Mistral_SE_01' if ($hlen == 10);
$attr{$name}{model} = "Grothe_Mistral_SE_03" if ($hlen == 12); $attr{$name}{model} = 'Grothe_Mistral_SE_03' if ($hlen == 12);
} }
my $model = AttrVal($name, "model", "unknown"); my $model = AttrVal($name, 'model', 'unknown');
Log3 $name, 4, "$ioname: SD_BELL_Parse $name model=$model state=$state ($rawData)"; Log3 $name, 4, "$ioname: SD_BELL_Parse $name model=$model state=$state ($rawData)";
readingsBeginUpdate($hash); readingsBeginUpdate($hash);
readingsBulkUpdate($hash, "state", $state); readingsBulkUpdate($hash, 'state', $state);
readingsBulkUpdate($hash, "batteryState", $bat) if (defined($bat) && length($bat) > 0) ; readingsBulkUpdate($hash, 'batteryState', $bat) if (defined($bat) && length($bat) > 0) ;
readingsEndUpdate($hash, 1); # Notify is done by Dispatch readingsEndUpdate($hash, 1); # Notify is done by Dispatch
return $name; return $name;
@ -411,26 +424,26 @@ sub Attr(@) {
my ($cmd, $name, $attrName, $attrValue) = @_; my ($cmd, $name, $attrName, $attrValue) = @_;
my $hash = $defs{$name}; my $hash = $defs{$name};
my $typ = $hash->{TYPE}; my $typ = $hash->{TYPE};
my $ioDev = InternalVal($name, "LASTInputDev", undef); my $ioDev = InternalVal($name, 'LASTInputDev', undef);
my $state; my $state;
my $oldmodel = AttrVal($name, "model", "unknown"); my $oldmodel = AttrVal($name, 'model', 'unknown');
my @hex_lengh_def = split(" ", $defs{$name}->{DEF}); my @hex_lengh_def = split(' ', $defs{$name}->{DEF});
my $hex_lengh = length($hex_lengh_def[1]); my $hex_lengh = length($hex_lengh_def[1]);
my $check_ok = 0; my $check_ok = 0;
#Log3 $name, 3, "SD_BELL_Attr cmd=$cmd attrName=$attrName attrValue=$attrValue oldmodel=$oldmodel"; #Log3 $name, 3, "SD_BELL_Attr cmd=$cmd attrName=$attrName attrValue=$attrValue oldmodel=$oldmodel";
if ($cmd eq "set" && $attrName eq "model" && $attrValue ne $oldmodel) { ### set new attr if ($cmd eq 'set' && $attrName eq 'model' && $attrValue ne $oldmodel) { ### set new attr
$check_ok = 1 if ($models{$attrValue}{hex_lengh} =~ /($hex_lengh)/); $check_ok = 1 if ($models{$attrValue}{hex_lengh} =~ /($hex_lengh)/xms);
return "SD_BELL: ERROR! You want to choose the $oldmodel model to $attrValue.\nPlease check your selection. Your HEX-Value in DEF with a length of " .$hex_lengh. " are not allowed on this model!" if ($check_ok != 1 && $hex_lengh != 0); return "SD_BELL: ERROR! You want to choose the $oldmodel model to $attrValue.\nPlease check your selection. Your HEX-Value in DEF with a length of " .$hex_lengh. ' are not allowed on this model!' if ($check_ok != 1 && $hex_lengh != 0);
Log3 $name, 3, "SD_BELL_Attr $cmd $attrName to $attrValue from $oldmodel"; Log3 $name, 3, "SD_BELL_Attr $cmd $attrName to $attrValue from $oldmodel";
} }
if ($cmd eq "del" && $attrName eq "model") { ### delete readings if ($cmd eq 'del' && $attrName eq 'model') { ### delete readings
readingsSingleUpdate($hash, "state" , "Please define a model for the correct processing",1); readingsSingleUpdate($hash, 'state' , 'Please define a model for the correct processing',1);
} }
return undef; return;
} }
1; 1;