mirror of
https://github.com/fhem/fhem-mirror.git
synced 2025-02-25 09:55:38 +00:00
37_SHC.pm: Avoid experimental given/when Perl feature and use if-elsif instead.
git-svn-id: https://svn.fhem.de/fhem/trunk@26457 2b470e98-0d58-463d-a4d8-8e2adae1ed80
This commit is contained in:
breaker27
parent
627f5278a8
commit
e775139e22
@ -2,7 +2,7 @@
|
||||
# This file is part of the smarthomatic module for FHEM.
|
||||
#
|
||||
# Copyright (c) 2014 Stefan Baumann
|
||||
# 2014, 2015, 2019 Uwe Freese
|
||||
# 2014, 2015, 2019, 2022 Uwe Freese
|
||||
#
|
||||
# You can find smarthomatic at www.smarthomatic.org.
|
||||
# You can find FHEM at www.fhem.de.
|
||||
@ -227,18 +227,15 @@ sub SHCdev_Parse($$)
|
||||
# remember PacketCounter (which every message provides)
|
||||
readingsBulkUpdate($rhash, "packetCounter", $packetcounter);
|
||||
|
||||
given ($msggroupname) {
|
||||
when ('Generic') {
|
||||
given ($msgname) {
|
||||
when ('Version') {
|
||||
if ($msggroupname eq "Generic") {
|
||||
if ($msgname eq "Version") {
|
||||
my $major = $parser->getField("Major");
|
||||
my $minor = $parser->getField("Minor");
|
||||
my $patch = $parser->getField("Patch");
|
||||
my $vhash = $parser->getField("Hash");
|
||||
|
||||
readingsBulkUpdate($rhash, "version", "$major.$minor.$patch-$vhash");
|
||||
}
|
||||
when ('DeviceInfo') {
|
||||
} elsif ($msgname eq "DeviceInfo") {
|
||||
my $devtype = $parser->getField("DeviceType");
|
||||
my $major = $parser->getField("VersionMajor");
|
||||
my $minor = $parser->getField("VersionMinor");
|
||||
@ -253,25 +250,19 @@ sub SHCdev_Parse($$)
|
||||
}
|
||||
|
||||
readingsBulkUpdate($rhash, "version", "$major.$minor.$patch-$vhash");
|
||||
}
|
||||
when ('HardwareError') {
|
||||
} elsif ($msgname eq "HardwareError") {
|
||||
readingsBulkUpdate($rhash, "hardwareErrorCode", $parser->getField("ErrorCode"));
|
||||
}
|
||||
when ('BatteryStatus') {
|
||||
} elsif ($msgname eq "BatteryStatus") {
|
||||
readingsBulkUpdate($rhash, "battery", $parser->getField("Percentage"));
|
||||
}
|
||||
}
|
||||
}
|
||||
when ('GPIO') {
|
||||
given ($msgname) {
|
||||
when ('DigitalPortTimeout') {
|
||||
} elsif ($msggroupname eq "GPIO") {
|
||||
if ($msgname eq "DigitalPortTimeout") {
|
||||
my $pins = "";
|
||||
for (my $i = 0 ; $i < 8 ; $i++) {
|
||||
my $pinx = $parser->getField("On", $i);
|
||||
my $timeoutx = $parser->getField("TimeoutSec", $i);
|
||||
my $channel = $i + 1;
|
||||
if ($channel == 1)
|
||||
{
|
||||
if ($channel == 1) {
|
||||
readingsBulkUpdate($rhash, "on", $pinx);
|
||||
}
|
||||
readingsBulkUpdate($rhash, "pin" . $channel, $pinx);
|
||||
@ -279,22 +270,19 @@ sub SHCdev_Parse($$)
|
||||
$pins .= $pinx;
|
||||
}
|
||||
readingsBulkUpdate($rhash, "port", $pins);
|
||||
}
|
||||
when ('DigitalPort') {
|
||||
} elsif ($msgname eq "DigitalPort") {
|
||||
my $pins = "";
|
||||
for (my $i = 0 ; $i < 8 ; $i++) {
|
||||
my $pinx = $parser->getField("On", $i);
|
||||
my $channel = $i + 1;
|
||||
if ($channel == 1)
|
||||
{
|
||||
if ($channel == 1) {
|
||||
readingsBulkUpdate($rhash, "on", $pinx);
|
||||
}
|
||||
readingsBulkUpdate($rhash, "pin" . $channel, $pinx);
|
||||
$pins .= $pinx;
|
||||
}
|
||||
readingsBulkUpdate($rhash, "port", $pins);
|
||||
}
|
||||
when ('AnalogPort') {
|
||||
} elsif ($msgname eq "AnalogPort") {
|
||||
my $pins = "";
|
||||
for (my $i = 0 ; $i < 5 ; $i++) {
|
||||
my $pinx_on = $parser->getField("On", $i);
|
||||
@ -306,91 +294,71 @@ sub SHCdev_Parse($$)
|
||||
}
|
||||
readingsBulkUpdate($rhash, "ains", $pins);
|
||||
}
|
||||
}
|
||||
}
|
||||
when ('Weather') {
|
||||
given ($msgname) {
|
||||
when ('Temperature') {
|
||||
} elsif ($msggroupname eq "Weather") {
|
||||
if ($msgname eq "Temperature") {
|
||||
my $tmp = $parser->getField("Temperature") / 100; # parser returns centigrade
|
||||
|
||||
readingsBulkUpdate($rhash, "temperature", $tmp);
|
||||
}
|
||||
when ('HumidityTemperature') {
|
||||
} elsif ($msgname eq "HumidityTemperature") {
|
||||
my $hum = $parser->getField("Humidity") / 10; # parser returns 1/10 percent
|
||||
my $tmp = $parser->getField("Temperature") / 100; # parser returns centigrade
|
||||
|
||||
readingsBulkUpdate($rhash, "humidity", $hum);
|
||||
readingsBulkUpdate($rhash, "temperature", $tmp);
|
||||
}
|
||||
when ('BarometricPressureTemperature') {
|
||||
} elsif ($msgname eq "BarometricPressureTemperature") {
|
||||
my $bar = $parser->getField("BarometricPressure") / 100; # parser returns pascal, use hPa
|
||||
my $tmp = $parser->getField("Temperature") / 100; # parser returns centigrade
|
||||
|
||||
readingsBulkUpdate($rhash, "barometric_pressure", $bar);
|
||||
readingsBulkUpdate($rhash, "temperature", $tmp);
|
||||
}
|
||||
when ('Humidity') {
|
||||
} elsif ($msgname eq "Humidity") {
|
||||
my $hum = $parser->getField("Humidity") / 10; # parser returns 1/10 percent
|
||||
|
||||
readingsBulkUpdate($rhash, "humidity", $hum);
|
||||
}
|
||||
}
|
||||
}
|
||||
when ('Environment') {
|
||||
given ($msgname) {
|
||||
when ('Brightness') {
|
||||
} elsif ($msggroupname eq "Environment") {
|
||||
if ($msgname eq "Brightness") {
|
||||
my $brt = $parser->getField("Brightness");
|
||||
readingsBulkUpdate($rhash, "brightness", $brt);
|
||||
}
|
||||
when ('Distance') {
|
||||
} elsif ($msgname eq "Distance") {
|
||||
my $brt = $parser->getField("Distance");
|
||||
readingsBulkUpdate($rhash, "distance", $brt);
|
||||
}
|
||||
when ('ParticulateMatter') {
|
||||
} elsif ($msgname eq "ParticulateMatter") {
|
||||
my $size = $parser->getField("TypicalParticleSize");
|
||||
|
||||
if ($size != 1023) # 1023 means invalid
|
||||
{
|
||||
if ($size != 1023) { # 1023 means invalid
|
||||
readingsBulkUpdate($rhash, "typicalParticleSize", $size / 100); # value was in 1/100 µm
|
||||
}
|
||||
|
||||
for (my $i = 0 ; $i < 5 ; $i++) {
|
||||
$size = $parser->getField("Size", $i);
|
||||
|
||||
if ($size) # 0 means array element not used
|
||||
{
|
||||
if ($size) { # 0 means array element not used
|
||||
my $pmStr = int($size / 10) . "." . ($size % 10);
|
||||
my $massConcentration = $parser->getField("MassConcentration", $i);
|
||||
my $numberConcentration = $parser->getField("NumberConcentration", $i);
|
||||
|
||||
if ($massConcentration != 1023) # 1023 means invalid
|
||||
{
|
||||
if ($massConcentration != 1023) { # 1023 means invalid
|
||||
readingsBulkUpdate($rhash, "massConcentration_PM" . $pmStr, $massConcentration / 10); # value was in 1/10 µm
|
||||
}
|
||||
|
||||
if ($numberConcentration != 4095) # 4095 means invalid
|
||||
{
|
||||
if ($numberConcentration != 4095) { # 4095 means invalid
|
||||
readingsBulkUpdate($rhash, "numberConcentration_PM" . $pmStr, $numberConcentration / 10); # value was in 1/10 µm
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
when ('Dimmer') {
|
||||
given ($msgname) {
|
||||
when ('Brightness') {
|
||||
} elsif ($msggroupname eq "Dimmer") {
|
||||
if ($msgname eq "Brightness") {
|
||||
my $brightness = $parser->getField("Brightness");
|
||||
my $on = $brightness == 0 ? 0 : 1;
|
||||
|
||||
readingsBulkUpdate($rhash, "on", $on);
|
||||
readingsBulkUpdate($rhash, "brightness", $brightness);
|
||||
}
|
||||
when ('Color') {
|
||||
} elsif ($msgname eq "Color") {
|
||||
my $color = $parser->getField("Color");
|
||||
readingsBulkUpdate($rhash, "color", $color);
|
||||
}
|
||||
when ('ColorAnimation') {
|
||||
} elsif ($msgname eq "ColorAnimation") {
|
||||
my $repeat = $parser->getField("Repeat");
|
||||
my $autoreverse = $parser->getField("AutoReverse");
|
||||
readingsBulkUpdate($rhash, "repeat", $repeat);
|
||||
@ -403,8 +371,6 @@ sub SHCdev_Parse($$)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
# If the devtype is defined add, if not already done, the according webCmds and devStateIcons
|
||||
my $devtype2 = AttrVal( $rname, "devtype", undef );
|
||||
@ -490,8 +456,7 @@ sub SHCdev_Set($@)
|
||||
|
||||
my $readonly = AttrVal($name, "readonly", "0");
|
||||
|
||||
given ($devtype) {
|
||||
when ('PowerSwitch') {
|
||||
if ($devtype eq "PowerSwitch") {
|
||||
|
||||
# Timeout functionality for SHCdev is not implemented, because FHEMs internal notification system
|
||||
# is able to do this as well. Even more it supports intervals, off-for-timer, off-till ...
|
||||
@ -551,8 +516,7 @@ sub SHCdev_Set($@)
|
||||
} else {
|
||||
return SetExtensions($hash, "", $name, @aa);
|
||||
}
|
||||
}
|
||||
when ('Dimmer') {
|
||||
} elsif ($devtype eq "Dimmer") {
|
||||
|
||||
# Timeout functionality for SHCdev is not implemented, because FHEMs internal notification system
|
||||
# is able to do this as well. Even more it supports intervals, off-for-timer, off-till ...
|
||||
@ -602,8 +566,7 @@ sub SHCdev_Set($@)
|
||||
} else {
|
||||
return SetExtensions($hash, "", $name, @aa);
|
||||
}
|
||||
}
|
||||
when ('RGBDimmer') {
|
||||
} elsif ($devtype eq "RGBDimmer") {
|
||||
if ($cmd eq 'Color') {
|
||||
#TODO Verify argument values
|
||||
my $color = $arg;
|
||||
@ -660,7 +623,6 @@ sub SHCdev_Set($@)
|
||||
return SetExtensions($hash, "", $name, @aa);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return undef;
|
||||
}
|
||||
@ -685,8 +647,7 @@ sub SHCdev_Get($@)
|
||||
return "No get commands for " . $devtype . " device type supported ";
|
||||
}
|
||||
|
||||
given ($devtype) {
|
||||
when ('EnvSensor') {
|
||||
if ($devtype eq "EnvSensor") {
|
||||
if ($cmd eq 'din') {
|
||||
if ($arg =~ /[1-8]/) {
|
||||
my $channel = "din" . $arg;
|
||||
@ -742,7 +703,6 @@ sub SHCdev_Get($@)
|
||||
# This return is required to provide the get commands in the web interface
|
||||
return "Unknown argument $cmd, choose one of " . $gets{$devtype};
|
||||
}
|
||||
}
|
||||
return undef;
|
||||
}
|
||||
|
||||
|
||||
@ -101,8 +101,7 @@ sub init_datafield_positions_noarray($$$$$)
|
||||
{
|
||||
my ($messageGroupID, $messageID, $field, $arrayLength, $arrayElementBits) = @_;
|
||||
|
||||
given ($field->nodeName) {
|
||||
when ('UIntValue') {
|
||||
if ($field->nodeName eq "UIntValue") {
|
||||
my $id = ($field->findnodes("ID"))[0]->textContent;
|
||||
my $bits = ($field->findnodes("Bits"))[0]->textContent;
|
||||
|
||||
@ -112,9 +111,7 @@ sub init_datafield_positions_noarray($$$$$)
|
||||
new UIntValue($id, $offset, $bits, $arrayLength, $arrayElementBits);
|
||||
|
||||
$offset += $bits;
|
||||
}
|
||||
|
||||
when ('IntValue') {
|
||||
} elsif ($field->nodeName eq "IntValue") {
|
||||
my $id = ($field->findnodes("ID"))[0]->textContent;
|
||||
my $bits = ($field->findnodes("Bits"))[0]->textContent;
|
||||
|
||||
@ -124,9 +121,7 @@ sub init_datafield_positions_noarray($$$$$)
|
||||
new IntValue($id, $offset, $bits, $arrayLength, $arrayElementBits);
|
||||
|
||||
$offset += $bits;
|
||||
}
|
||||
|
||||
when ('FloatValue') {
|
||||
} elsif ($field->nodeName eq "FloatValue") {
|
||||
my $id = ($field->findnodes("ID"))[0]->textContent;
|
||||
my $bits = 32;
|
||||
|
||||
@ -136,9 +131,7 @@ sub init_datafield_positions_noarray($$$$$)
|
||||
new FloatValue($id, $offset, $arrayLength, $arrayElementBits);
|
||||
|
||||
$offset += $bits;
|
||||
}
|
||||
|
||||
when ('BoolValue') {
|
||||
} elsif ($field->nodeName eq "BoolValue") {
|
||||
my $id = ($field->findnodes("ID"))[0]->textContent;
|
||||
my $bits = 1;
|
||||
|
||||
@ -148,9 +141,7 @@ sub init_datafield_positions_noarray($$$$$)
|
||||
new BoolValue($id, $offset, $arrayLength, $arrayElementBits);
|
||||
|
||||
$offset += $bits;
|
||||
}
|
||||
|
||||
when ('EnumValue') {
|
||||
} elsif ($field->nodeName eq "EnumValue") {
|
||||
my $id = ($field->findnodes("ID"))[0]->textContent;
|
||||
my $bits = ($field->findnodes("Bits"))[0]->textContent;
|
||||
|
||||
@ -171,7 +162,6 @@ sub init_datafield_positions_noarray($$$$$)
|
||||
$offset += $bits;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
sub init_datafield_positions_array($$$)
|
||||
{
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user