From e29d8f1be311bc37c9633e19dce9a76992847b1a Mon Sep 17 00:00:00 2001
From: betateilchen <>
Date: Wed, 26 Feb 2014 12:55:59 +0000
Subject: [PATCH] added: attribute gdsPassiveFtp

git-svn-id: https://svn.fhem.de/fhem/trunk@5052 2b470e98-0d58-463d-a4d8-8e2adae1ed80
---
 fhem/FHEM/55_GDS.pm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/fhem/FHEM/55_GDS.pm b/fhem/FHEM/55_GDS.pm
index 975f1504c..8216ada09 100644
--- a/fhem/FHEM/55_GDS.pm
+++ b/fhem/FHEM/55_GDS.pm
@@ -63,7 +63,7 @@ sub GDS_Initialize($) {
 	$hash->{AttrFn}		=	"GDS_Attr";
 	$hash->{AttrList}	=	"gdsFwName gdsFwType:0,1,2,3,4,5,6,7 ".
 							"gdsAll:0,1 gdsDebug:0,1 gdsLong:0,1 gdsPolygon:0,1 ".
-							"gdsSetCond ".
+							"gdsSetCond gdsPassiveFtp:0,1 ".
 							$readingFnAttributes;
 
 	$tempDir = "c:\\temp\\" if($^O eq "MSWin32");
@@ -693,6 +693,7 @@ sub retrieveFile($$;$$$){
 	my $pass		= $hash->{helper}{PASS};
 	my $proxyName	= AttrVal($name, "gdsProxyName", "");
 	my $proxyType	= AttrVal($name, "gdsProxyType", "");
+	my $passive		= AttrVal($name, "gdsPassiveFtp", 0);
 	my $debug		= AttrVal($name, "gdsDebug",0);
 
 	my ($dwd, $dir, $ftp, @files, $dataFile, $targetFile, $found, $readingName);
@@ -779,6 +780,7 @@ sub retrieveFile($$;$$$){
 		$ftp = Net::FTP->new(	"ftp-outgoing2.dwd.de",
 								Debug => 0,
 								Timeout => 10,
+								Passive => $passive,
 								FirewallType => $proxyType,
 								Firewall => $proxyName);
 		Log3($name, 4, "GDS $name: ftp connection established.");
@@ -1090,6 +1092,8 @@ sub initDropdownLists($){
 #	2014-02-04	added	ShutdownFn
 #				changed	FTP Timeout
 #
+#	2014-02-26	added	attribute gdsPassiveFtp
+#
 ####################################################################################################
 #
 # Further informations
@@ -1264,6 +1268,7 @@ sub initDropdownLists($){
 		<li><b>gdsLong</b> - show long text fields "description" and "instruction" from alert message in readings</li>
 		<li><b>gdsPolygon</b> - show polygon data from alert message in a reading</li>
 		<br/>
+		<li><b>gdsPassiveFtp</b> - set to 1 to use passive FTP transfer</li>
 		<li><b>gdsFwName</b> - define firewall hostname in format &lt;hostname&gt;:&lt;port&gt;</li>
 		<li><b>gdsFwType</b> - define firewall type in a value 0..7 please refer to <a href="http://search.cpan.org/~gbarr/libnet-1.22/Net/Config.pm#NetConfig_VALUES">cpan documentation</a> for further informations regarding firewall settings.</li>
 	</ul>