From d6b070704a73cc91c6cb1fea4248820df03dfa06 Mon Sep 17 00:00:00 2001 From: eisler Date: Wed, 5 Sep 2018 15:51:19 +0000 Subject: [PATCH] 12_HProtocolGateway: minor bug fixes git-svn-id: https://svn.fhem.de/fhem/trunk@17278 2b470e98-0d58-463d-a4d8-8e2adae1ed80 --- fhem/FHEM/12_HProtocolGateway.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fhem/FHEM/12_HProtocolGateway.pm b/fhem/FHEM/12_HProtocolGateway.pm index 923a2e079..86eae226b 100644 --- a/fhem/FHEM/12_HProtocolGateway.pm +++ b/fhem/FHEM/12_HProtocolGateway.pm @@ -119,7 +119,7 @@ sub HProtocolGateway_GetUpdate($) { $command = "\$C"; } - my $msg = $command . $tankHash->{READINGS}{hID}{VAL} . "\r\n"; + my $msg = $command . $tankHash->{READINGS}{hID}{VAL} . "\r\n"; DevIo_SimpleWrite($hash, $msg , 2); my ($err, $data) = HProtocolGateway_ReadAnswer($hash,$tankHash); Log3 $name, 5, "err:". $err; @@ -188,7 +188,7 @@ sub HProtocolGateway_ParseMessage($$) { $data =~ s/^.//; # remove # my ($tankdata,$water,$temperature,$probe_offset,$version,$error,$checksum)=split(/@/,$data); - my $test = "#".$data.$water.$temperature.$probe_offset.$version.$error; + my $test = "#".$tankdata.$water.$temperature.$probe_offset.$version.$error; # calculate XOR CRC my $check = 0; @@ -198,7 +198,7 @@ sub HProtocolGateway_ParseMessage($$) { return if($check ne $checksum); - my ($filllevel,$volume,$ullage) = 0; + my ($filllevel,$volume,$ullage) = (0,0,0); if ($attr{$name}{mode} eq "Filllevel") { $filllevel = $tankdata; @@ -365,12 +365,12 @@ sub HProtocolGateway_Tank($$$) { my $volume = 0; foreach my $level (sort keys %TankChartHash) { - if ($messwert <= $level && $level ne "level") { + if ($level ne "level" && $messwert <= $level) { $volume = $TankChartHash{$level}; last; } } - retun $volume; + return $volume; } 1;