From d06a6d9897c4728bff9587c9e33ea8967f0078be Mon Sep 17 00:00:00 2001
From: borisneubert <>
Date: Sat, 26 Jan 2013 21:46:29 +0000
Subject: [PATCH] set does not return a value any more made state setting
 compliant with guidelines

git-svn-id: https://svn.fhem.de/fhem/trunk@2572 2b470e98-0d58-463d-a4d8-8e2adae1ed80
---
 fhem/FHEM/67_ECMDDevice.pm | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/fhem/FHEM/67_ECMDDevice.pm b/fhem/FHEM/67_ECMDDevice.pm
index 355dd0e23..24c5f8948 100644
--- a/fhem/FHEM/67_ECMDDevice.pm
+++ b/fhem/FHEM/67_ECMDDevice.pm
@@ -95,15 +95,21 @@ sub
 ECMDDevice_Changed($$$)
 {
         my ($hash, $cmd, $value)= @_;
+        
 
-        readingsSingleUpdate($hash, $cmd, $value, 1);
+        readingsBeginUpdate($hash);
+        readingsBulkUpdate($hash, $cmd, $value, 1) if(defined($value));
 
-        $hash->{STATE} = "$cmd $value";
+        my $state= $cmd;
+        $state.= " $value" if(defined($value));
+        readingsBulkUpdate($hash, "state", $state, 0);
+
+        readingsEndUpdate($hash, 1);
 
         my $name= $hash->{NAME};
-        Log GetLogLevel($name, 4), "ECMDDevice $name $cmd: $value";
+        Log GetLogLevel($name, 4), "ECMDDevice $name $state";
 
-        return $hash->{STATE};
+        return $state;
 
 }
 
@@ -220,9 +226,8 @@ ECMDDevice_Set($@)
 
 	$v= ECMDDevice_PostProc($hash, $postproc, $v);
 
-#        $v= join(" ", @a) if($params);
-
-        return ECMDDevice_Changed($hash, $cmdname, $v);
+        ECMDDevice_Changed($hash, $cmdname, $v); # was: return ECMDDevice_Changed($hash, $cmdname, $v);
+        return undef;
 
 }