FHEM/fhem-mirror
2
0
Fork 0
mirror of https://github.com/fhem/fhem-mirror.git synced 2025-01-31 06:39:11 +00:00
Code Issues Releases Wiki Activity

36_Shelly: illegal division when attr Periods is not set (ShellyPro3EM)

Browse Source 
git-svn-id: https://svn.fhem.de/fhem/trunk@29291 2b470e98-0d58-463d-a4d8-8e2adae1ed80
This commit is contained in:
Starkstrombastler 2024-10-25 13:24:56 +00:00
parent 07cdc039ce
commit c99648f9e0
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
fhem/CHANGED
View File

@ -1,5 +1,6 @@
# Add changes at the top of the list. Keep it in ASCII, and 80-char wide. # Add changes at the top of the list. Keep it in ASCII, and 80-char wide.
# Do not insert empty lines here, update check depends on it # Do not insert empty lines here, update check depends on it
- bugfix: 36_Shelly: ShellyPro3EM: div by zero when attr Periods is not set
- bugfix: 36_Shelly: diverse Korrekturen/Ergänzungen/siehe Forum - bugfix: 36_Shelly: diverse Korrekturen/Ergänzungen/siehe Forum
- bugfix: 76_SolarForecast: minor fix in Flowgraphic - bugfix: 76_SolarForecast: minor fix in Flowgraphic
- bufgix: 72_FRITZBOX: Perl Warning behoben - bufgix: 72_FRITZBOX: Perl Warning behoben

7
fhem/FHEM/36_Shelly.pm
View File

@ -121,6 +121,7 @@
# change: use 'blank' sign instead of removing '%20' when displaying actions urls # change: use 'blank' sign instead of removing '%20' when displaying actions urls
# change: on updating action query strings, substitue spaces by '+' sign, instead of %20 (Shelly fw replace %20 by space) # change: on updating action query strings, substitue spaces by '+' sign, instead of %20 (Shelly fw replace %20 by space)
# fix: removed lost '&' when webhooks changed to have no csrf token # fix: removed lost '&' when webhooks changed to have no csrf token
# 6.01.1 fix: division by zero when attr Periods is not set at ShellyPro3EM
# to do roller: get maxtime open/close from shelly gen1 # to do roller: get maxtime open/close from shelly gen1
# get status on stopp even when interval == 0 # get status on stopp even when interval == 0
@ -143,7 +144,7 @@ sub Shelly_Set ($@);
sub Shelly_status(@); sub Shelly_status(@);
#-- globals on start #-- globals on start
my $version = "6.01 24.10.2024"; my $version = "6.01.1 25.10.2024";
my $defaultINTERVAL = 60; my $defaultINTERVAL = 60;
my $multiplyIntervalOnError = 1.0; # mechanism disabled if value=1 my $multiplyIntervalOnError = 1.0; # mechanism disabled if value=1
@ -5536,9 +5537,9 @@ sub Shelly_procEMData {
if( $hash->{INTERVAL}>0 ){ if( $hash->{INTERVAL}>0 ){
#-- initiate next run, adjusted to full minute plus 1 sec #-- initiate next run, adjusted to full minute plus 1 sec
my $perds = AttrVal($name,"Periods", ""); my $perds = AttrVal($name,"Periods", "min");
$perds=~/(\w+)$/; # \w matches all word chars, looking for last key in descending order $perds=~/(\w+)$/; # \w matches all word chars, looking for last key in descending order
my $timer=$periods{$1}[2]; my $timer=$periods{$1}[2]; $timer=60 if( !defined($timer) || $timer==0 );
my $Time=(int(time()/$timer)+1)*$timer+1; my $Time=(int(time()/$timer)+1)*$timer+1;
Log3 $name,4,"[Shelly_procEMData] $name: \'EM Data\' update interval is $timer sec, next update \@ ".strftime("%H:%M:%S",localtime($Time)); #4 Log3 $name,4,"[Shelly_procEMData] $name: \'EM Data\' update interval is $timer sec, next update \@ ".strftime("%H:%M:%S",localtime($Time)); #4
RemoveInternalTimer($hash,"Shelly_getEMData"); RemoveInternalTimer($hash,"Shelly_getEMData");