FHEM/fhem-mirror
2
0
Fork 0
mirror of https://github.com/fhem/fhem-mirror.git synced 2025-01-31 18:59:33 +00:00
Code Issues Releases Wiki Activity

SOMFY: Bugfix for wrong attributename when calculating the updatetime.

Browse Source 
The attribute was misspelled, so the updatetime when driving up
was not calculated correctly.

Also updated the version to 1.5

git-svn-id: https://svn.fhem.de/fhem/trunk@7988 2b470e98-0d58-463d-a4d8-8e2adae1ed80
This commit is contained in:
thomyd 2015-02-14 22:04:45 +00:00
parent 5c919a2f98
commit a02724fe83
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
fhem/CHANGED
View File

@ -1,5 +1,6 @@
# Add changes at the top of the list. Keep it in ASCII, and 80-char wide.
# Do not insert empty lines here, update check depends on it.
- bugfix: SOMFY: use correct attributename when calculating updatetime
- feature: 95_FLOORPLAN.pm: arrange by drag&drop,
copy, rename, delete processes userattr fp_<name>
- added: 30_LIGHTIFY.pm: New module for OSRAM LIGHTIFY gateways

11
fhem/FHEM/10_SOMFY.pm
View File

@ -1,11 +1,10 @@
######################################################
# $Id$
# $Id: 10_SOMFY.pm 6645 2014-10-01 07:55:26Z thomyd $
#
# SOMFY RTS / Simu Hz protocol module for FHEM
# (c) Thomas Dankert <post@thomyd.de>
#
# This will only work if you flashed your CUL with
# the newest culfw (support for "Y" command).
# Needs CULFW V 1.59 or higher (support for "Y" command).
#
# Published under GNU GPL License, v2
#
@ -27,6 +26,8 @@
#
# 1.4 thomyd Implemented fallback on/off-for-timer methods and only show warning about stop/go-my
# if the positioning attributes are set.
#
# 1.5 thomyd Bugfix for wrong attribute names when calculating the updatetime (drive-up-...)
######################################################
@ -388,7 +389,7 @@ sub SOMFY_CalcNewPos($) {
if($oldpos > 100) {
$dt = $dt - $t1up100;
$newpos = $oldpos - (100 * $dt / ($t1upopen - $t1up100));
$newpos = 100 if($newpos > 100), # driven only short between close and pos 100!
$newpos = 100 if($newpos > 100); # driven only short between close and pos 100!
} else {
$newpos = $oldpos - (100 * $dt / ($t1upopen - $t1up100));
@ -469,7 +470,7 @@ sub SOMFY_Set($@) {
$cmd = 'off';
$hash->{move} = 'up';
$newpos = 0;
$updatetime = (AttrVal($name,'drive-up-time-open',25) - AttrVal($name,'drive-up-time-100',0)) * $oldpos / 100;
$updatetime = (AttrVal($name,'drive-up-time-to-open',25) - AttrVal($name,'drive-up-time-to-100',0)) * $oldpos / 100;
} elsif ($cmd eq 'on') {
$hash->{move} = 'down';