From 8f7b4a09211b4e145f43ff09decd2436704ebe37 Mon Sep 17 00:00:00 2001 From: borisneubert <> Date: Thu, 2 Oct 2014 17:44:53 +0000 Subject: [PATCH] 57_Calendar: deal with non-existent end times git-svn-id: https://svn.fhem.de/fhem/trunk@6654 2b470e98-0d58-463d-a4d8-8e2adae1ed80 --- fhem/CHANGED | 1 + fhem/FHEM/57_Calendar.pm | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/fhem/CHANGED b/fhem/CHANGED index 22f3627fc..1b09d2884 100644 --- a/fhem/CHANGED +++ b/fhem/CHANGED @@ -1,5 +1,6 @@ # Add changes at the top of the list. Keep it in ASCII, and 80-char wide. # Do not insert empty lines here, update check depends on it. + - feature: 57_Calendar: deal with non-existent end times - bugfix: SOMFY: fix non-working on/off-for-timer methods made positioning attributes optional - feature: SOMFY: support for exact positioning (one-time setup of run times required) diff --git a/fhem/FHEM/57_Calendar.pm b/fhem/FHEM/57_Calendar.pm index 8b10800a9..f999e7677 100644 --- a/fhem/FHEM/57_Calendar.pm +++ b/fhem/FHEM/57_Calendar.pm @@ -622,12 +622,18 @@ sub isAlarmed { sub isStarted { my ($self,$t) = @_; return 0 if($self->isDeleted()); - return $self->{start}<= $t && $t< $self->{end} ? 1 : 0; + return 0 unless(defined($self->{start})); + return 0 if($t < $self->{start}); + if(defined($self->{end})) { + return 0 if($t>= $self->{end}); + } + return 1; } sub isEnded { my ($self,$t) = @_; return 0 if($self->isDeleted()); + return 0 unless(defined($self->{end})); return $self->{end}<= $t ? 1 : 0; }