FHEM/fhem-mirror
2
0
Fork 0
mirror of https://github.com/fhem/fhem-mirror.git synced 2025-04-05 11:38:47 +00:00
Code Issues Releases Wiki Activity

98_weekprofile: fix warning: Use of uninitialized value $type in concatenation (.) or string

Browse Source 
CHG: check model before chanNo

git-svn-id: https://svn.fhem.de/fhem/trunk@11264 2b470e98-0d58-463d-a4d8-8e2adae1ed80
This commit is contained in:
risiko79 2016-04-17 10:59:59 +00:00
parent 96428c8241
commit 84cf32c1a1
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
fhem/FHEM/98_weekprofile.pm
View File

@ -60,17 +60,24 @@ sub weekprofile_getDeviceType($$;$)
}
my $type = undef;
if ($devHash->{TYPE} =~ /CUL_HM/){
my $model = AttrVal($device,"model","");
#models: HM-TC-IT-WM-W-EU, HM-CC-RT-DN, HM-CC-TC
unless ($model =~ m/.*HM-[C|T]C-.*/) {
Log3 $me, 4, "$me(getDeviceType): $devHash->{NAME}, model $model is not supported";
return undef;
}
if (!defined($devHash->{chanNo})) { #no channel device
Log3 $me, 4, "$me(getDeviceType): $devHash->{NAME}, $model, has no chanNo";
Log3 $me, 4, "$me(getDeviceType): $devHash->{NAME}, model $model has no chanNo";
return undef;
}
my $channel = $devHash->{chanNo};
unless ($channel =~ /^\d+?$/) {
Log3 $me, 4, "$me(getDeviceType): $devHash->{NAME}, $model, chanNo $channel is no number";
Log3 $me, 4, "$me(getDeviceType): $devHash->{NAME}, model $model chanNo $channel is no number";
return undef;
}
@ -96,7 +103,11 @@ sub weekprofile_getDeviceType($$;$)
$type = "WEEKPROFILE";
}
Log3 $me, 5, "$me(getDeviceType): $devHash->{NAME} is type $type";
if (defined($type)) {
Log3 $me, 4, "$me(getDeviceType): $devHash->{NAME} is type $type";
} else {
Log3 $me, 4, "$me(getDeviceType): $devHash->{NAME} is not supported";
}
return $type;
}