From 6d3b1c751762d6afee3efd5887c74a631c30f6f2 Mon Sep 17 00:00:00 2001
From: nasseeder1 <nasseeder1@users.noreply.github.com>
Date: Mon, 7 Oct 2019 22:34:08 +0000
Subject: [PATCH] 93_DbLog: enhanced configCheck, minor fix warning

git-svn-id: https://svn.fhem.de/fhem/trunk@20329 2b470e98-0d58-463d-a4d8-8e2adae1ed80
---
 fhem/CHANGED          |  1 +
 fhem/FHEM/93_DbLog.pm | 19 ++++++++++++++++++-
 2 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/fhem/CHANGED b/fhem/CHANGED
index 09a9c72d2..16e966ef7 100644
--- a/fhem/CHANGED
+++ b/fhem/CHANGED
@@ -1,5 +1,6 @@
 # Add changes at the top of the list. Keep it in ASCII, and 80-char wide.
 # Do not insert empty lines here, update check depends on it.
+ - change:  93_DbLog: enhanced configCheck, minor fix warning
  - feature: 93_DbRep: seqDoubletsVariance - separate specification of positive 
                       and negative variance possible, 
                       (Forum: 53584.msg959963.html#msg959963)
diff --git a/fhem/FHEM/93_DbLog.pm b/fhem/FHEM/93_DbLog.pm
index 992f4cdc0..6dd3cacc0 100644
--- a/fhem/FHEM/93_DbLog.pm
+++ b/fhem/FHEM/93_DbLog.pm
@@ -30,6 +30,8 @@ no if $] >= 5.017011, warnings => 'experimental::smartmatch';
 
 # Version History intern by DS_Starter:
 our %DbLog_vNotesIntern = (
+  "4.7.5"   => "07.10.2019 fix warning \"error valueFn: Global symbol \$CN requires ...\" in DbLog_addCacheLine ".
+                           "enhanced configCheck by insert mode check ",
   "4.7.4"   => "03.10.2019 bugfix test of TIMESTAMP got from DbLogValueFn or valueFn in DbLog_Log and DbLog_AddLog",
   "4.7.3"   => "02.10.2019 improved log out entries of DbLog_Get for SVG ",
   "4.7.2"   => "28.09.2019 change cache from %defs to %data ",
@@ -3727,6 +3729,7 @@ sub DbLog_configcheck($) {
   ### Check Betriebsmodus
   #######################################################################
   my $mode = $hash->{MODE};
+  my $bi   = AttrVal($name, "bulkInsert", 0);
   my $sfx = AttrVal("global", "language", "EN");
   $sfx = ($sfx eq "EN" ? "" : "_$sfx");
   
@@ -3745,7 +3748,20 @@ sub DbLog_configcheck($) {
 	  $rec .= "There are attributes 'syncInterval' and 'cacheLimit' relevant for this working mode. <br>";
 	  $rec .= "Please refer to commandref for further information about these attributes.";
   }
-  $check .= "<b>Recommendation:</b> $rec <br><br>"; 
+  $check .= "<b>Recommendation:</b> $rec <br><br>";
+
+  $check .= "<u><b>Result of insert mode check</u></b><br><br>";
+  if(!$bi) {
+      $bi     = "Array";
+      $check .= "Insert mode of DbLog-device $name is: $bi <br>";
+      $rec    = "Setting attribute \"bulkInsert\" to \"1\" may result a higher write performance in most cases. ";
+      $rec   .= "Feel free to try this mode.";
+  } else {
+      $bi     = "Bulk";
+      $check .= "Insert mode of DbLog-device $name is: $bi <br>"; 
+      $rec    = "settings o.k.";   
+  }  
+  $check .= "<b>Recommendation:</b> $rec <br><br>";
   
   ### Check Plot Erstellungsmodus
   #######################################################################
@@ -4485,6 +4501,7 @@ sub DbLog_addCacheLine($$$$$$$$) {
  	  my $VALUE 	 = $i_val;
  	  my $UNIT   	 = $i_unit;
 	  my $IGNORE     = 0;
+      my $CN         = " ";
 
  	  eval $value_fn;
 	  Log3 $name, 2, "DbLog $name -> error valueFn: ".$@ if($@);