46_TeslaPowerwall2AC: Code rewrite for new Auth API andmodulstructure

git-svn-id: https://svn.fhem.de/fhem/trunk@24109 2b470e98-0d58-463d-a4d8-8e2adae1ed80

fhem/CHANGED

@@ -1,5 +1,7 @@
 # Add changes at the top of the list. Keep it in ASCII, and 80-char wide.
 # Do not insert empty lines here, update check depends on it.
+ - change:  46_TeslaPowerwall2AC: Code rewrite for new Auth API and
+                                  modul structure
  - new:     69_SoftliqCloud: New Module
  - change:  47_OBIS: more robustness for changing polltime / interval
  - feature: 72_TA_CMI_JSON: added internal NODEID_HEX

fhem/FHEM/46_TeslaPowerwall2AC.pm

@@ -2,7 +2,7 @@
 #
 # Developed with Kate
 #
-#  (c) 2017-2020 Copyright: Marko Oldenburg (leongaultier at gmail dot com)
+#  (c) 2017-2021 Copyright: Marko Oldenburg (fhemdevelopment at cooltux dot net)
 #  All rights reserved
 #
 #  This script is free software; you can redistribute it and/or modify
@@ -58,79 +58,8 @@ use strict;
 use warnings;
 use FHEM::Meta;
 use GPUtils qw(GP_Import GP_Export);
-use HttpUtils;
-use Data::Dumper;
 
-# try to use JSON::MaybeXS wrapper
+require FHEM::Tesla::Powerwall;
-#   for chance of better performance + open code
-eval {
-    require JSON::MaybeXS;
-    import JSON::MaybeXS qw( decode_json encode_json );
-    1;
-};
-
-if ($@) {
-    $@ = undef;
-
-    # try to use JSON wrapper
-    #   for chance of better performance
-    eval {
-
-        # JSON preference order
-        local $ENV{PERL_JSON_BACKEND} =
-          'Cpanel::JSON::XS,JSON::XS,JSON::PP,JSON::backportPP'
-          unless ( defined( $ENV{PERL_JSON_BACKEND} ) );
-
-        require JSON;
-        import JSON qw( decode_json encode_json );
-        1;
-    };
-
-    if ($@) {
-        $@ = undef;
-
-        # In rare cases, Cpanel::JSON::XS may
-        #   be installed but JSON|JSON::MaybeXS not ...
-        eval {
-            require Cpanel::JSON::XS;
-            import Cpanel::JSON::XS qw(decode_json encode_json);
-            1;
-        };
-
-        if ($@) {
-            $@ = undef;
-
-            # In rare cases, JSON::XS may
-            #   be installed but JSON not ...
-            eval {
-                require JSON::XS;
-                import JSON::XS qw(decode_json encode_json);
-                1;
-            };
-
-            if ($@) {
-                $@ = undef;
-
-                # Fallback to built-in JSON which SHOULD
-                #   be available since 5.014 ...
-                eval {
-                    require JSON::PP;
-                    import JSON::PP qw(decode_json encode_json);
-                    1;
-                };
-
-                if ($@) {
-                    $@ = undef;
-
-                    # Fallback to JSON::backportPP in really rare cases
-                    require JSON::backportPP;
-                    import JSON::backportPP qw(decode_json encode_json);
-                    1;
-                }
-            }
-        }
-    }
-}
 
 ## Import der FHEM Funktionen
 #-- Run before package compilation
@@ -139,24 +68,8 @@ BEGIN {
     # Import from main context
     GP_Import(
         qw(
-          readingsSingleUpdate
-          readingsBulkUpdate
-          readingsBulkUpdateIfChanged
-          readingsBeginUpdate
-          readingsEndUpdate
-          CommandAttr
-          defs
-          Log3
           readingFnAttributes
-          HttpUtils_NonblockingGet
+          )
-          AttrVal
-          ReadingsVal
-          IsDisabled
-          deviceEvents
-          init_done
-          gettimeofday
-          InternalTimer
-          RemoveInternalTimer)
     );
 }
 
@@ -164,664 +77,36 @@ BEGIN {
 GP_Export(
     qw(
       Initialize
-      Timer_GetData
-      Write
       )
 );
 
-my %paths = (
+sub Initialize {
-    'statussoe'    => 'system_status/soe',
-    'aggregates'   => 'meters/aggregates',
-    'meterssite'   => 'meters/site',
-    'meterssolar'  => 'meters/solar',
-    'siteinfo'     => 'site_info',
-    'sitename'     => 'site_info/site_name',
-    'sitemaster'   => 'sitemaster',
-    'powerwalls'   => 'powerwalls',
-    'registration' => 'customer/registration',
-    'status'       => 'status',
-    'login'        => 'login/Basic',
-    'gridstatus'   => 'system_status/grid_status',
-);
 
-my %cmdPaths = (
+    my $hash            = shift;
-    'powerwallsstop' => 'sitemaster/stop',
-    'powerwallsrun'  => 'sitemaster/run',
-);
 
-sub Initialize($) {
+    $hash->{GetFn}          = 'FHEM::Tesla::Powerwall::Get';
+    $hash->{SetFn}          = 'FHEM::Tesla::Powerwall::Set';
+    $hash->{DefFn}          = 'FHEM::Tesla::Powerwall::Define';
+    $hash->{UndefFn}        = 'FHEM::Tesla::Powerwall::Undef';
+    $hash->{NotifyFn}       = 'FHEM::Tesla::Powerwall::Notify';
+    $hash->{RenameFn}       = 'FHEM::Tesla::Powerwall::Rename';
 
-    my ($hash) = @_;
+    $hash->{AttrFn}         = 'FHEM::Tesla::Powerwall::Attr';
-
-    # Consumer
-    $hash->{GetFn}    = 'FHEM::TeslaPowerwall2AC::Get';
-    $hash->{SetFn}    = 'FHEM::TeslaPowerwall2AC::Set';
-    $hash->{DefFn}    = 'FHEM::TeslaPowerwall2AC::Define';
-    $hash->{UndefFn}  = 'FHEM::TeslaPowerwall2AC::Undef';
-    $hash->{NotifyFn} = 'FHEM::TeslaPowerwall2AC::Notify';
-
-    $hash->{AttrFn} = 'FHEM::TeslaPowerwall2AC::Attr';
     $hash->{AttrList}       =
-      'interval ' . 'disable:1 ' . 'devel:1 ' . $readingFnAttributes;
+                      'interval '
+                    . 'disable:1 '
+                    . 'devel:1 '
+                    . 'emailaddr '
+                    . $readingFnAttributes;
+
+    $hash->{parseParams}    = 1;
 
     return FHEM::Meta::InitMod( __FILE__, $hash );
 }
 
-sub Define($$) {
-    my ( $hash, $def ) = @_;
-    my @a = split( '[ \t][ \t]*', $def );
-
-    return $@ unless ( FHEM::Meta::SetInternals($hash) );
-    use version 0.60; our $VERSION = FHEM::Meta::Get( $hash, 'version' );
-
-    return 'too few parameters: define <name> TeslaPowerwall2AC <HOST>'
-      if ( @a != 3 );
-
-    my $name = $a[0];
-
-    my $host = $a[2];
-    $hash->{HOST}        = $host;
-    $hash->{INTERVAL}    = 300;
-    $hash->{VERSION}     = version->parse($VERSION)->normal;
-    $hash->{NOTIFYDEV}   = "global,$name";
-    $hash->{actionQueue} = [];
-
-    CommandAttr( undef, $name . ' room Tesla' )
-      if ( AttrVal( $name, 'room', 'none' ) eq 'none' );
-    Log3 $name, 3,
-"TeslaPowerwall2AC ($name) - defined TeslaPowerwall2AC Device with Host $host and Interval $hash->{INTERVAL}";
-
-    return undef;
-}
-
-sub Undef($$) {
-    my ( $hash, $arg ) = @_;
-    my $name = $hash->{NAME};
-
-    RemoveInternalTimer($hash);
-    Log3 $name, 3, "TeslaPowerwall2AC ($name) - Device $name deleted";
-
-    return undef;
-}
-
-sub Attr(@) {
-    my ( $cmd, $name, $attrName, $attrVal ) = @_;
-    my $hash = $defs{$name};
-
-    if ( $attrName eq 'disable' ) {
-        if ( $cmd eq 'set' and $attrVal eq '1' ) {
-            RemoveInternalTimer($hash);
-            readingsSingleUpdate( $hash, 'state', 'disabled', 1 );
-            Log3 $name, 3, "TeslaPowerwall2AC ($name) - disabled";
-
-        }
-        elsif ( $cmd eq 'del' ) {
-            Log3 $name, 3, "TeslaPowerwall2AC ($name) - enabled";
-        }
-    }
-
-    if ( $attrName eq 'disabledForIntervals' ) {
-        if ( $cmd eq 'set' ) {
-            return
-'check disabledForIntervals Syntax HH:MM-HH:MM or \'HH:MM-HH:MM HH:MM-HH:MM ...\''
-              unless ( $attrVal =~ /^((\d{2}:\d{2})-(\d{2}:\d{2})\s?)+$/ );
-            Log3 $name, 3, "TeslaPowerwall2AC ($name) - disabledForIntervals";
-            readingsSingleUpdate( $hash, 'state', 'disabled', 1 );
-
-        }
-        elsif ( $cmd eq 'del' ) {
-            Log3 $name, 3, "TeslaPowerwall2AC ($name) - enabled";
-            readingsSingleUpdate( $hash, 'state', 'active', 1 );
-        }
-    }
-
-    if ( $attrName eq 'interval' ) {
-        if ( $cmd eq 'set' ) {
-            if ( $attrVal < 60 ) {
-                Log3 $name, 3,
-"TeslaPowerwall2AC ($name) - interval too small, please use something >= 60 (sec), default is 300 (sec)";
-                return
-'interval too small, please use something >= 60 (sec), default is 300 (sec)';
-
-            }
-            else {
-                RemoveInternalTimer($hash);
-                $hash->{INTERVAL} = $attrVal;
-                Log3 $name, 3,
-                  "TeslaPowerwall2AC ($name) - set interval to $attrVal";
-                Timer_GetData($hash);
-            }
-        }
-        elsif ( $cmd eq 'del' ) {
-            RemoveInternalTimer($hash);
-            $hash->{INTERVAL} = 300;
-            Log3 $name, 3,
-              "TeslaPowerwall2AC ($name) - set interval to default";
-            Timer_GetData($hash);
-        }
-    }
-
-    return undef;
-}
-
-sub Notify($$) {
-    my ( $hash, $dev ) = @_;
-    my $name = $hash->{NAME};
-    return if ( IsDisabled($name) );
-
-    my $devname = $dev->{NAME};
-    my $devtype = $dev->{TYPE};
-    my $events  = deviceEvents( $dev, 1 );
-    return if ( !$events );
-
-    Timer_GetData($hash)
-      if (
-        grep /^INITIALIZED$/,
-        @{$events} or grep /^DELETEATTR.$name.disable$/,
-        @{$events} or grep /^DELETEATTR.$name.interval$/,
-        @{$events} or ( grep /^DEFINED.$name$/, @{$events} and $init_done )
-      );
-    return;
-}
-
-sub Get($@) {
-    my ( $hash, $name, $cmd ) = @_;
-    my $arg;
-
-    if ( $cmd eq 'statusSOE' ) {
-
-        $arg = lc($cmd);
-
-    }
-    elsif ( $cmd eq 'aggregates' ) {
-
-        $arg = lc($cmd);
-
-    }
-    elsif ( $cmd eq 'siteinfo' ) {
-
-        $arg = lc($cmd);
-
-    }
-    elsif ( $cmd eq 'powerwalls' ) {
-
-        $arg = lc($cmd);
-
-    }
-    elsif ( $cmd eq 'sitemaster' ) {
-
-        $arg = lc($cmd);
-
-    }
-    elsif ( $cmd eq 'registration' ) {
-
-        $arg = lc($cmd);
-
-    }
-    elsif ( $cmd eq 'status' ) {
-
-        $arg = lc($cmd);
-
-    }
-    else {
-
-        my $list =
-'statusSOE:noArg aggregates:noArg siteinfo:noArg sitemaster:noArg powerwalls:noArg registration:noArg status:noArg';
-
-        return 'Unknown argument ' . $cmd . ', choose one of ' . $list;
-    }
-
-    return 'There are still path commands in the action queue'
-      if ( defined( $hash->{actionQueue} )
-        and scalar( @{ $hash->{actionQueue} } ) > 0 );
-
-    unshift( @{ $hash->{actionQueue} }, $arg );
-    Write($hash);
-
-    return undef;
-}
-
-sub Set($@) {
-    my ( $hash, $name, $cmd, @args ) = @_;
-    my $arg;
-
-    if ( $cmd eq 'powerwalls' ) {
-        $arg = lc( $cmd . $args[0] );
-    }
-    else {
-
-        my $list = '';
-        $list .= 'powerwalls:run,stop'
-          if ( AttrVal( $name, 'devel', 0 ) == 1 );
-
-        return 'Unknown argument ' . $cmd . ', choose one of ' . $list;
-    }
-
-    unshift( @{ $hash->{actionQueue} }, $arg );
-    Write($hash);
-
-    return undef;
-}
-
-sub Timer_GetData($) {
-    my $hash = shift;
-    my $name = $hash->{NAME};
-
-    RemoveInternalTimer($hash);
-
-    if ( defined( $hash->{actionQueue} )
-        and scalar( @{ $hash->{actionQueue} } ) == 0 )
-    {
-        if ( not IsDisabled($name) ) {
-            while ( my $obj = each %paths ) {
-                unshift( @{ $hash->{actionQueue} }, $obj );
-            }
-
-            Write($hash);
-
-        }
-        else {
-            readingsSingleUpdate( $hash, 'state', 'disabled', 1 );
-        }
-    }
-
-    InternalTimer( gettimeofday() + $hash->{INTERVAL},
-        'TeslaPowerwall2AC_Timer_GetData', $hash );
-    Log3 $name, 4,
-      "TeslaPowerwall2AC ($name) - Call InternalTimer Timer_GetData";
-}
-
-sub Write($) {
-    my ($hash) = @_;
-    my $name = $hash->{NAME};
-
-    my ( $uri, $method, $header, $data, $path ) =
-      CreateUri( $hash, pop( @{ $hash->{actionQueue} } ) );
-
-    readingsSingleUpdate(
-        $hash,
-        'state',
-        'fetch data - '
-          . scalar( @{ $hash->{actionQueue} } )
-          . ' entries in the Queue',
-        1
-    );
-
-    HttpUtils_NonblockingGet(
-        {
-            url       => 'https://' . $uri,
-            timeout   => 5,
-            method    => $method,
-            data      => $data,
-            header    => $header,
-            hash      => $hash,
-            setCmd    => $path,
-            doTrigger => 1,
-            callback  => \&ErrorHandling,
-        }
-    );
-
-    Log3 $name, 4, "TeslaPowerwall2AC ($name) - Send with URI: https://$uri";
-}
-
-sub ErrorHandling($$$) {
-    my ( $param, $err, $data ) = @_;
-    my $hash = $param->{hash};
-    my $name = $hash->{NAME};
-
-    ### Begin Error Handling
-
-    if ( defined($err) ) {
-        if ( $err ne '' ) {
-
-            readingsBeginUpdate($hash);
-            readingsBulkUpdate( $hash, 'state',            $err, 1 );
-            readingsBulkUpdate( $hash, 'lastRequestError', $err, 1 );
-            readingsEndUpdate( $hash, 1 );
-
-            Log3 $name, 3, "TeslaPowerwall2AC ($name) - RequestERROR: $err";
-
-            $hash->{actionQueue} = [];
-            return;
-        }
-    }
-
-    if ( $data eq '' and exists( $param->{code} ) && $param->{code} != 200 ) {
-
-        readingsBeginUpdate($hash);
-        readingsBulkUpdate( $hash, 'state', $param->{code}, 1 );
-
-        readingsBulkUpdate( $hash, 'lastRequestError', $param->{code}, 1 );
-
-        Log3 $name, 3,
-          "TeslaPowerwall2AC ($name) - RequestERROR: " . $param->{code};
-
-        readingsEndUpdate( $hash, 1 );
-
-        Log3 $name, 5,
-            "TeslaPowerwall2AC ($name) - RequestERROR: received http code "
-          . $param->{code}
-          . " without any data after requesting";
-
-        $hash->{actionQueue} = [];
-        return;
-    }
-
-    if ( $data =~ m#{"code":(\d+),"error":"(.+)","message":"(.+)"}$# ) {
-
-        readingsBeginUpdate($hash);
-
-        readingsBulkUpdate( $hash, 'state', $1, 1 );
-        readingsBulkUpdate(
-            $hash,
-            'lastRequestError',
-            'Path: '
-              . $param->{setCmd} . ' '
-              . $1
-              . ' - Error: '
-              . $2
-              . ' Messages: '
-              . $3,
-            1
-        );
-
-        readingsEndUpdate( $hash, 1 );
-    }
-    #### End Error Handling
-
-    InternalTimer( gettimeofday() + 3, 'TeslaPowerwall2AC_Write', $hash )
-      if ( defined( $hash->{actionQueue} )
-        and scalar( @{ $hash->{actionQueue} } ) > 0 );
-
-    Log3 $name, 4, "TeslaPowerwall2AC ($name) - Recieve JSON data: $data";
-
-    ResponseProcessing( $hash, $param->{setCmd}, $data );
-}
-
-sub ResponseProcessing($$$) {
-    my ( $hash, $path, $json ) = @_;
-    my $name = $hash->{NAME};
-    my $decode_json;
-    my $readings;
-
-    $decode_json = eval { decode_json($json) };
-    if ($@) {
-        Log3 $name, 4, "TeslaPowerwall2AC ($name) - error while request: $@";
-        readingsBeginUpdate($hash);
-        readingsBulkUpdate( $hash, 'JSON Error', $@ );
-        readingsBulkUpdate( $hash, 'state',      'JSON error' );
-        readingsEndUpdate( $hash, 1 );
-        return;
-    }
-
-    return
-      if (  ref($decode_json) eq 'HASH'
-        and defined( $decode_json->{error} )
-        and $decode_json->{error}
-        and defined( $decode_json->{code} )
-        and $decode_json->{code} );
-
-    #### Verarbeitung der Readings zum passenden Path
-
-    if ( $path eq 'aggregates' ) {
-        $readings = ReadingsProcessing_Aggregates( $hash, $decode_json );
-    }
-    elsif ( $path eq 'powerwalls' ) {
-        $readings = ReadingsProcessing_Powerwalls( $hash, $decode_json );
-    }
-    elsif ( $path eq 'login' ) {
-        return $hash->{TOKEN} = $decode_json->{token};
-    }
-    elsif ( $path eq 'meterssite' ) {
-        $readings = ReadingsProcessing_Meters_Site( $hash, $decode_json );
-    }
-    elsif ( $path eq 'meterssolar' ) {
-        $readings = ReadingsProcessing_Meters_Solar( $hash, $decode_json );
-    }
-    else {
-        $readings = $decode_json;
-    }
-
-    WriteReadings( $hash, $path, $readings );
-}
-
-sub WriteReadings($$$) {
-    my ( $hash, $path, $readings ) = @_;
-    my $name = $hash->{NAME};
-
-    Log3 $name, 4, "TeslaPowerwall2AC ($name) - Write Readings";
-
-    readingsBeginUpdate($hash);
-    while ( my ( $r, $v ) = each %{$readings} ) {
-        readingsBulkUpdate( $hash, $path . '-' . $r, $v );
-    }
-
-    readingsBulkUpdate( $hash, 'batteryLevel',
-        sprintf( "%.1f", $readings->{percentage} ) )
-      if ( defined( $readings->{percentage} ) );
-    readingsBulkUpdate(
-        $hash,
-        'batteryPower',
-        sprintf(
-            "%.1f",
-            (
-                ReadingsVal( $name, 'siteinfo-nominal_system_energy_kWh', 0 ) /
-                  100
-            ) * ReadingsVal( $name, 'statussoe-percentage', 0 )
-        )
-    );
-    readingsBulkUpdateIfChanged( $hash, 'actionQueue',
-        scalar( @{ $hash->{actionQueue} } ) . ' entries in the Queue' );
-    readingsBulkUpdateIfChanged(
-        $hash, 'state',
-        (
-            defined( $hash->{actionQueue} )
-              and scalar( @{ $hash->{actionQueue} } ) == 0
-            ? 'ready'
-            : 'fetch data - '
-              . scalar( @{ $hash->{actionQueue} } )
-              . ' paths in actionQueue'
-        )
-    );
-    readingsEndUpdate( $hash, 1 );
-}
-
-sub ReadingsProcessing_Aggregates($$) {
-    my ( $hash, $decode_json ) = @_;
-    my $name = $hash->{NAME};
-    my %readings;
-
-    if ( ref($decode_json) eq 'HASH' ) {
-        while ( my $obj = each %{$decode_json} ) {
-            while ( my ( $r, $v ) = each %{ $decode_json->{$obj} } ) {
-                $readings{ $obj . '-' . $r } = $v;
-            }
-        }
-    }
-    else {
-        $readings{'error'} = 'aggregates response is not a Hash';
-    }
-
-    return \%readings;
-}
-
-sub ReadingsProcessing_Powerwalls($$) {
-    my ( $hash, $decode_json ) = @_;
-    my $name = $hash->{NAME};
-    my %readings;
-
-    if ( ref( $decode_json->{powerwalls} ) eq 'ARRAY'
-        and scalar( @{ $decode_json->{powerwalls} } ) > 0 )
-    {
-        my $i = 0;
-        foreach my $powerwall ( @{ $decode_json->{powerwalls} } ) {
-            if ( ref($powerwall) eq 'HASH' ) {
-
-                while ( my ( $r, $v ) = each %{$powerwall} ) {
-                    $readings{ 'wall_' . $i . '_' . $r } = $v;
-                }
-
-                $i++;
-            }
-        }
-
-        $readings{'numberOfWalls'} = $i;
-    }
-    else {
-        $readings{'error'} = 'aggregates response is not a Array';
-    }
-
-    return \%readings;
-}
-
-sub ReadingsProcessing_Site_Info($$) {
-    my ( $hash, $decode_json ) = @_;
-    my $name = $hash->{NAME};
-    my %readings;
-
-    if ( ref($decode_json) eq 'HASH' ) {
-        while ( my $obj = each %{$decode_json} ) {
-            while ( my ( $r, $v ) = each %{ $decode_json->{$obj} } ) {
-                $readings{ $obj . '-' . $r } = $v;
-            }
-        }
-    }
-    else {
-        $readings{'error'} = 'siteinfo response is not a Hash';
-    }
-
-    return \%readings;
-}
-
-sub ReadingsProcessing_Meters_Site($$) {
-    my ( $hash, $decode_json ) = @_;
-    my $name = $hash->{NAME};
-    my %readings;
-
-    if ( ref($decode_json) eq 'ARRAY'
-        and scalar( @{$decode_json} ) > 0 )
-    {
-        if ( ref( $decode_json->[0] ) eq 'HASH' ) {
-            while ( my $obj = each %{ $decode_json->[0] } ) {
-                if (   ref( $decode_json->[0]->{$obj} ) eq 'ARRAY'
-                    or ref( $decode_json->[0]->{$obj} ) eq 'HASH' )
-                {
-                    if ( ref( $decode_json->[0]->{$obj} ) eq 'HASH' ) {
-                        while ( my ( $r, $v ) =
-                            each %{ $decode_json->[0]->{$obj} } )
-                        {
-                            if ( ref($v) ne 'HASH' ) {
-                                $readings{ $obj . '-' . $r } = $v;
-                            }
-                            else {
-                                while ( my ( $r2, $v2 ) =
-                                    each %{ $decode_json->[0]->{$obj}->{$r} } )
-                                {
-                                    $readings{ $obj . '-' . $r . '-' . $r2 } =
-                                      $v2;
-                                }
-                            }
-                        }
-                    }
-                    elsif ( ref( $decode_json->[0]->{$obj} ) eq 'ARRAY' ) {
-
-                    }
-                }
-                else {
-                    $readings{$obj} = $decode_json->[0]->{$obj};
-                }
-            }
-        }
-    }
-    else {
-        $readings{'error'} = 'metes site response is not a Array';
-    }
-
-    return \%readings;
-}
-
-sub ReadingsProcessing_Meters_Solar($$) {
-    my ( $hash, $decode_json ) = @_;
-    my $name = $hash->{NAME};
-    my %readings;
-
-    if ( ref($decode_json) eq 'ARRAY'
-        and scalar( @{$decode_json} ) > 0 )
-    {
-        if ( ref( $decode_json->[0] ) eq 'HASH' ) {
-            while ( my $obj = each %{ $decode_json->[0] } ) {
-                if (   ref( $decode_json->[0]->{$obj} ) eq 'ARRAY'
-                    or ref( $decode_json->[0]->{$obj} ) eq 'HASH' )
-                {
-                    if ( ref( $decode_json->[0]->{$obj} ) eq 'HASH' ) {
-                        while ( my ( $r, $v ) =
-                            each %{ $decode_json->[0]->{$obj} } )
-                        {
-                            if ( ref($v) ne 'HASH' ) {
-                                $readings{ $obj . '-' . $r } = $v;
-                            }
-                            else {
-                                while ( my ( $r2, $v2 ) =
-                                    each %{ $decode_json->[0]->{$obj}->{$r} } )
-                                {
-                                    $readings{ $obj . '-' . $r . '-' . $r2 } =
-                                      $v2;
-                                }
-                            }
-                        }
-                    }
-                    elsif ( ref( $decode_json->[0]->{$obj} ) eq 'ARRAY' ) {
-
-                    }
-                }
-                else {
-                    $readings{$obj} = $decode_json->[0]->{$obj};
-                }
-            }
-        }
-    }
-    else {
-        $readings{'error'} = 'metes solar response is not a Array';
-    }
-
-    return \%readings;
-}
-
-sub CreateUri($$) {
-    my ( $hash, $path ) = @_;
-    my $host   = $hash->{HOST};
-    my $method = 'GET';
-    my $uri;
-    my $header;
-    my $data;
-
-    if (   $path eq 'powerwallsstop'
-        or $path eq 'powerwallsruns' )
-    {
-        $uri = $host . '/api/' . $cmdPaths{$path};
-    }
-    else {
-        $uri = $host . '/api/' . $paths{$path};
-    }
-
-    if ( $path eq 'sitemasterrun' ) {
-        $header = 'Authorization: Bearer' . $hash->{TOKEN};
-
-    }
-    elsif ( $path eq 'login' ) {
-        $method = 'POST';
-        $header = 'Content-Type: application/json';
-        $data   = '{"username":"","password":"S'
-          . ReadingsVal( $hash->{NAME},
-            'powerwalls-wall_0_PackageSerialNumber', 0 )
-          . '","force_sm_off":false}';
-    }
-
-    return ( $uri, $method, $header, $data, $path );
-}
-
 1;
 
+
 =pod
 
 =item device
@@ -865,6 +150,8 @@ sub CreateUri($$) {
         <li>state           - information about internel modul processes</li>
         <li>status-*        - readings of the /api/status response</li>
         <li>statussoe-*     - readings of the /api/system_status/soe response</li>
+        <li>setPassword     - write password encrypted to password file</li>
+        <li>removePassword  - remove password from password file</li>
     </ul>
     <a name="TeslaPowerwall2ACget"></a>
     <b>get</b>
@@ -877,10 +164,19 @@ sub CreateUri($$) {
         <li>status          - fetch data from url path /api/status</li>
         <li>statussoe       - fetch data from url path /api/system_status/soe</li>
     </ul>
+    <br><br>
+    <a name="TeslaPowerwall2ACset"></a>
+    <b>set</b>
+    <ul>
+        <li>removePassword  - remove password from password file</li>
+        <li>setPassword     - save password in passswordfile ATTANTION!!! text must begin with pass= (Example: pass=meinpassword)</li>
+    </ul>
+    <br><br>
     <a name="TeslaPowerwall2ACattribute"></a>
     <b>Attribute</b>
     <ul>
         <li>interval - interval in seconds for automatically fetch data (default 300)</li>
+        <li>emailaddr - emailadress to get cookie token</li>
     </ul>
 </ul>
 
@@ -909,9 +205,9 @@ sub CreateUri($$) {
     "Powerwall",
     "Control"
   ],
-  "release_status": "under develop",
+  "release_status": "stable",
   "license": "GPL_2",
-  "version": "v0.8.0",
+  "version": "v1.2.0",
   "author": [
     "Marko Oldenburg <leongaultier@gmail.com>"
   ],