From 50b11436aeaa529411fdd2ed8369e44e601e1a23 Mon Sep 17 00:00:00 2001
From: martinp876 <>
Date: Tue, 17 Jun 2014 05:44:54 +0000
Subject: [PATCH] speedup apptime, comments in HMInfo

git-svn-id: https://svn.fhem.de/fhem/trunk@6126 2b470e98-0d58-463d-a4d8-8e2adae1ed80
---
 fhem/FHEM/98_HMinfo.pm  | 12 +++++-------
 fhem/FHEM/98_apptime.pm | 16 ++++++++++------
 2 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/fhem/FHEM/98_HMinfo.pm b/fhem/FHEM/98_HMinfo.pm
index 52ecaa700..65f3d2772 100644
--- a/fhem/FHEM/98_HMinfo.pm
+++ b/fhem/FHEM/98_HMinfo.pm
@@ -1679,8 +1679,8 @@ sub HMinfo_noDup(@) {#return list with no duplicates###########################
   <ul><code><br>
            set hm update<br>
   </code></ul><br>
-  Webview of HMinfo will provide details, basically counter about how
-  many CUL_HM entities experience exceptional conditions. Areas provided are
+  Webview of HMinfo providee details, basically counter about how
+  many CUL_HM entities experience exceptional conditions. It contains
   <ul>
       <li>Action Detector status</li>
       <li>CUL_HM related IO devices and condition</li>
@@ -1693,9 +1693,9 @@ sub HMinfo_noDup(@) {#return list with no duplicates###########################
   It also allows some HM wide commands such
   as store all collected register settings.<br><br>
 
-  Commands will be executed on all HM entities of the installation.
+  Commands are executed on all HM entities.
   If applicable and evident execution is restricted to related entities.
-  In fact, rssi is executed on devices only because channels do not support rssi values.<br><br>
+  e.g. rssi is executed on devices only since channels do not support rssi values.<br><br>
   <a name="HMinfoFilter"><b>Filter</b></a>
   <ul>  can be applied as following:<br><br>
         <code>set &lt;name&gt; &lt;cmd&gt; &lt;filter&gt; [&lt;param&gt;]</code><br>
@@ -1762,9 +1762,7 @@ sub HMinfo_noDup(@) {#return list with no duplicates###########################
           statistic about message transferes over a week<br>
       </li>
       <li><a name="#HMinfoprotoEvents">protoEvents </a><a href="#HMinfoFilter">[filter]</a> <br>
-          this is likely a very <B>important view</B> for message incidents.
-          Information about pending commands and - much more relevant - about failed executions 
-          is given in a table over all devices.<br>
+          <B>important view</B> about pending commands and failed executions for all devices in a single table.<br>
           Consider to clear this statistic use <a name="#HMinfoclear">clear Protocol</a>.<br>
       </li>
       <li><a name="#HMinforssi">rssi </a><a href="#HMinfoFilter">[filter]</a><br>
diff --git a/fhem/FHEM/98_apptime.pm b/fhem/FHEM/98_apptime.pm
index 6f774ad20..321859dd8 100644
--- a/fhem/FHEM/98_apptime.pm
+++ b/fhem/FHEM/98_apptime.pm
@@ -107,7 +107,7 @@ sub apptime_getTiming($$$@) {
   $ts1 = int((gettimeofday()-$ts1)*1000);
   if ($ts1 && $h->{max}<$ts1){
     $h->{max}=$ts1;
-    $h->{mAr}=join ("; ",@arg);
+    $h->{mAr}= \@arg;
   }
 
   $h->{tot}+=$ts1;
@@ -139,11 +139,15 @@ sub apptime_CommandDispTiming($$@) {
       ($n,$t) = split(";",$f,2) if ($d eq "global");
       $t = "" if (!defined $t);
       my $h = $defs{$d}{helper}{bm}{$f};
-          
-      my $arg = $h->{mAr};
-      foreach (@a){
-        my ($h,$n) = split(":",$_);
-        $arg =~ s/$h/$n/g; 
+
+      my $arg = "";
+      if ($h->{mAr}){
+        foreach my $i (0..scalar(@{$h->{mAr}})){ 
+          if(ref(${$h->{mAr}}[$i]) eq 'HASH' and exists(${$h->{mAr}}[$i]->{NAME})){
+            ${$h->{mAr}}[$i] = "HASH(".${$h->{mAr}}[$i]->{NAME}.")";
+          }
+        }
+        $arg = join ("; ",@{$h->{mAr}});
       }
 
       push @bmArr,[($n,$t