From 1f35e1c7ec9bd03d6b287649b24f31f1e1f0b32c Mon Sep 17 00:00:00 2001 From: Skjall <> Date: Sun, 19 Aug 2018 06:12:22 +0000 Subject: [PATCH] Vallox: Initialization bug fixed git-svn-id: https://svn.fhem.de/fhem/trunk@17170 2b470e98-0d58-463d-a4d8-8e2adae1ed80 --- fhem/CHANGED | 1 + fhem/FHEM/36_Vallox.pm | 10 ++++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/fhem/CHANGED b/fhem/CHANGED index cd3b40f81..90aa83cc4 100644 --- a/fhem/CHANGED +++ b/fhem/CHANGED @@ -1,5 +1,6 @@ # Add changes at the top of the list. Keep it in ASCII, and 80-char wide. # Do not insert empty lines here, update check depends on it. + - bugfix: 36_Vallox: Initialization bug fixed - added: 00_MQTT: ability for client notifications: on connect, on disconnect, on timeout - fixed: 00_MQTT: failure on handling with mqtt-devices without diff --git a/fhem/FHEM/36_Vallox.pm b/fhem/FHEM/36_Vallox.pm index b890f9862..cf98f2af9 100644 --- a/fhem/FHEM/36_Vallox.pm +++ b/fhem/FHEM/36_Vallox.pm @@ -5,7 +5,7 @@ # # @Author Skjall # @Created 21.07.2016 10:18:23 -# @Version 1.5.0 +# @Version 1.6.1 # # The modul reads and writes parameters via RS485 from and to a Vallox # ventilation bus. @@ -1603,19 +1603,21 @@ sub Vallox_Get($@) { # "reading" is a predefined list of readings from the bus if ( $cmd eq "reading" ) { + my $msg; + if ($arg eq "CO2SetPoint") { - my $msg = Vallox_CreateMsg( $hash, "b3" ); + $msg = Vallox_CreateMsg( $hash, "b3" ); DevIo_SimpleWrite( $hash, $msg, 1 ); Log3( $name, 3, "Vallox: Request " . $msg . " has been sent." ); - my $msg = Vallox_CreateMsg( $hash, "b4" ); + $msg = Vallox_CreateMsg( $hash, "b4" ); DevIo_SimpleWrite( $hash, $msg, 1 ); Log3( $name, 3, "Vallox: Request " . $msg . " has been sent." ); } else { my $argKey = $Vallox_datatypesReverse{$arg}; - my $msg = Vallox_CreateMsg( $hash, $argKey ); + $msg = Vallox_CreateMsg( $hash, $argKey ); DevIo_SimpleWrite( $hash, $msg, 1 );