From 0c955f4876ba31447b09174347db7dcc8c6248ea Mon Sep 17 00:00:00 2001 From: betateilchen <> Date: Sat, 12 Apr 2014 22:32:18 +0000 Subject: [PATCH] 55_weco.pm - some code cleanup git-svn-id: https://svn.fhem.de/fhem/trunk@5515 2b470e98-0d58-463d-a4d8-8e2adae1ed80 --- fhem/FHEM/55_weco.pm | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/fhem/FHEM/55_weco.pm b/fhem/FHEM/55_weco.pm index beed66043..2b442492c 100644 --- a/fhem/FHEM/55_weco.pm +++ b/fhem/FHEM/55_weco.pm @@ -40,17 +40,14 @@ use HttpUtils; sub weco_Initialize($) { my ($hash) = @_; - my $name = $hash->{NAME}; - my $found; $hash->{DefFn} = "weco_Define"; $hash->{UndefFn} = "weco_Undef"; - $hash->{AttrList} = "disable:0,1 ". - "wecoInterval:600,1800,3600 wecotest:true,false ". - "wecohu wecote wecodp wecopr wecopcv wecopcf wecowd wecows wecowsbft wecowg wecopa ". - "wecopai wecopaest wecouv wecosd wecosc wecovi wecoch wecocm wecocl wecodc wecoww ". - $readingFnAttributes; - + $hash->{AttrList} = "disable:1,0 ". + "wecoInterval:600,1800,3600 wecotest:true,false ". + "wecohu wecote wecodp wecopr wecopcv wecopcf wecowd wecows wecowsbft wecowg wecopa ". + "wecopai wecopaest wecouv wecosd wecosc wecovi wecoch wecocm wecocl wecodc wecoww ". + $readingFnAttributes; } sub weco_Define($$$) { @@ -102,8 +99,8 @@ sub weco_send($) { $key = substr($key,4,length($key)-4); ($d, $r, $o) = split(":", $value); if(defined($r)) { - $o = 0 if(!defined($o)); - $value = ReadingsVal($d, $r, "") + $o; + $o = (defined($o)) ? $o : 0; + $value = ReadingsVal($d, $r, 0) + $o; } $data .= "&$key=$value"; }